diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-08 04:00:36 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-08 04:00:36 +0000 |
commit | da463967e200fe91ccc3384db8f8ba34c08f3847 (patch) | |
tree | ba720771cabfc0d3a2463de69b15faf65c061e31 /base/allocator | |
parent | 53bfa860a4ede0a1f85f02b8d9d8a3896b6b0eb2 (diff) | |
download | chromium_src-da463967e200fe91ccc3384db8f8ba34c08f3847.zip chromium_src-da463967e200fe91ccc3384db8f8ba34c08f3847.tar.gz chromium_src-da463967e200fe91ccc3384db8f8ba34c08f3847.tar.bz2 |
Remove all uses of GG_LONGLONG and GG_ULONGLONG.
123LL and 123ULL now work everywhere. You can also use INT64_C and
UINT64_C (from <stdint.h>) in Chromium code (we force-define
__STDC_CONSTANT_MACROS). (And sometimes you can just use
static_cast<(u)int64_t>.)
Don't remove their definitions yet, because some macros that are
multiply-defined (in an identical way) rely on them. D'oh.
R=brettw@chromium.org
TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262147
Review URL: https://codereview.chromium.org/218953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262294 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/allocator')
-rw-r--r-- | base/allocator/allocator_unittest.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/base/allocator/allocator_unittest.cc b/base/allocator/allocator_unittest.cc index 4265251..eb20b38 100644 --- a/base/allocator/allocator_unittest.cc +++ b/base/allocator/allocator_unittest.cc @@ -5,6 +5,7 @@ #include <stdio.h> #include <stdlib.h> #include <algorithm> // for min() + #include "base/atomicops.h" #include "testing/gtest/include/gtest/gtest.h" @@ -81,8 +82,6 @@ static int NextSize(int size) { } } -#define GG_ULONGLONG(x) static_cast<uint64>(x) - template <class AtomicType> static void TestAtomicIncrement() { // For now, we just test single threaded execution @@ -164,7 +163,7 @@ static void TestCompareAndSwap() { // Use test value that has non-zero bits in both halves, more for testing // 64-bit implementation on 32-bit platforms. - const AtomicType k_test_val = (GG_ULONGLONG(1) << + const AtomicType k_test_val = (static_cast<uint64_t>(1) << (NUM_BITS(AtomicType) - 2)) + 11; value = k_test_val; prev = base::subtle::NoBarrier_CompareAndSwap(&value, 0, 5); @@ -187,7 +186,7 @@ static void TestAtomicExchange() { // Use test value that has non-zero bits in both halves, more for testing // 64-bit implementation on 32-bit platforms. - const AtomicType k_test_val = (GG_ULONGLONG(1) << + const AtomicType k_test_val = (static_cast<uint64_t>(1) << (NUM_BITS(AtomicType) - 2)) + 11; value = k_test_val; new_value = base::subtle::NoBarrier_AtomicExchange(&value, k_test_val); @@ -205,7 +204,7 @@ template <class AtomicType> static void TestAtomicIncrementBounds() { // Test increment at the half-width boundary of the atomic type. // It is primarily for testing at the 32-bit boundary for 64-bit atomic type. - AtomicType test_val = GG_ULONGLONG(1) << (NUM_BITS(AtomicType) / 2); + AtomicType test_val = static_cast<uint64_t>(1) << (NUM_BITS(AtomicType) / 2); AtomicType value = test_val - 1; AtomicType new_value = base::subtle::NoBarrier_AtomicIncrement(&value, 1); EXPECT_EQ(test_val, value); |