summaryrefslogtreecommitdiffstats
path: root/base/at_exit.h
diff options
context:
space:
mode:
authorscottbyer@chromium.org <scottbyer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-25 20:36:33 +0000
committerscottbyer@chromium.org <scottbyer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-25 20:36:33 +0000
commitfe992bf04826c6f7a067704a2fa117eda813d0fa (patch)
tree169cc41bb183542dbe526f6814c4d79fce6c7867 /base/at_exit.h
parentc9236ae784665dc4583e3c98a2b6c0280c21c8bd (diff)
downloadchromium_src-fe992bf04826c6f7a067704a2fa117eda813d0fa.zip
chromium_src-fe992bf04826c6f7a067704a2fa117eda813d0fa.tar.gz
chromium_src-fe992bf04826c6f7a067704a2fa117eda813d0fa.tar.bz2
Revert 144488 - For unit tests, track additions to AtExitManager and warn.
While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/at_exit.h')
-rw-r--r--base/at_exit.h9
1 files changed, 1 insertions, 8 deletions
diff --git a/base/at_exit.h b/base/at_exit.h
index 0aa7958..6fe7361 100644
--- a/base/at_exit.h
+++ b/base/at_exit.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -14,8 +14,6 @@
namespace base {
-class TestWatchAtExitManager;
-
// This class provides a facility similar to the CRT atexit(), except that
// we control when the callbacks are executed. Under Windows for a DLL they
// happen at a really bad time and under the loader lock. This facility is
@@ -59,11 +57,6 @@ class BASE_EXPORT AtExitManager {
explicit AtExitManager(bool shadow);
private:
- friend class TestWatchAtExitManager;
-
- static AtExitManager* current();
- size_t CallbackStackSize() const;
-
base::Lock lock_;
std::stack<base::Closure> stack_;
AtExitManager* next_manager_; // Stack of managers to allow shadowing.