diff options
| author | primiano <primiano@chromium.org> | 2015-11-02 08:43:28 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-02 16:44:08 +0000 |
| commit | 252503f31e82b5bcfde4c35930e61685a71d5d9a (patch) | |
| tree | 722bebe61d93beebed6ed915ca4dbdec69cd7dda /base/atomicops_internals_mac.h | |
| parent | 97585a9ddc05519be5acdef4bcbb51a0b6bcb848 (diff) | |
| download | chromium_src-252503f31e82b5bcfde4c35930e61685a71d5d9a.zip chromium_src-252503f31e82b5bcfde4c35930e61685a71d5d9a.tar.gz chromium_src-252503f31e82b5bcfde4c35930e61685a71d5d9a.tar.bz2 | |
[tracing] heap-profiler: Use explicit ConvertableToTraceFormat cast
crrev.com/1427063002 introduced a new overload to the
TRACE_EVENT_API_ADD_METADATA_EVENT api which takes a generic template
as argument. This causes the heap-profiler code in
memory_dump_manager.cc to prefer picking the bool cast operator of
scoped_refptr<DerivedClassWhichExtendsConvertable> rather than
the upcast operator to scoped_refptr<Convertable>.
In practical terms this means that invoking
TRACE_EVENT_API_ADD_METADATA_EVENT("name", scoped_refptr<Derived>)
expands to TRACE_EVENT_API_ADD_METADATA_EVENT("name", true) and does
not invoke the AppendAsTraceFormat() virtual method.
Using the explicit scoped_refptr<Convertable> when invoking the
TRACE_EVENT_API_ADD_METADATA_EVENT to fix the situation.
BUG=542702,524631
Review URL: https://codereview.chromium.org/1429883003
Cr-Commit-Position: refs/heads/master@{#357373}
Diffstat (limited to 'base/atomicops_internals_mac.h')
0 files changed, 0 insertions, 0 deletions