diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-18 01:18:29 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-18 01:18:29 +0000 |
| commit | a366880f8475fa9e0e70ace062af10654b297574 (patch) | |
| tree | 5c2a777d77feebefc4b8c0f0c78525d57be93b16 /base/base.gyp | |
| parent | c811184533d882af419cab0dabe0bf317c6c985f (diff) | |
| download | chromium_src-a366880f8475fa9e0e70ace062af10654b297574.zip chromium_src-a366880f8475fa9e0e70ace062af10654b297574.tar.gz chromium_src-a366880f8475fa9e0e70ace062af10654b297574.tar.bz2 | |
Remove CrApplication dependency from base
Add a @protocol CrAppProtocol that clients of base must implement in their NSApplication subclass, and let base depend only on this protocol.
Let MessagePumpNSApplication::DoRun() no longer initialize NSApplication (fixes a TODO).
Add a MockCrApplication that the simple unittests in base and app can use, move chrome_application to chrome/common.
Test shell might run nested run loops, so I gave it a real but simplified CrAppProtocol implementation.
BUG=62968,46929
TEST=Everything still works. The PDF plugin prints one fewer warning when loaded.
Review URL: http://codereview.chromium.org/5950003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69615 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gyp')
| -rw-r--r-- | base/base.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/base/base.gyp b/base/base.gyp index f4ddeb5..4c72e8b 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -257,6 +257,8 @@ ], 'sources': [ 'perftimer.cc', + 'test/mock_chrome_application_mac.h', + 'test/mock_chrome_application_mac.mm', 'test/multiprocess_test.cc', 'test/multiprocess_test.h', 'test/perf_test_suite.cc', |