diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 17:38:30 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 17:38:30 +0000 |
| commit | d0767cb54b2b5ee4d9cf00b3ee0fa585826b4036 (patch) | |
| tree | 1c2ee733bf62a44c31dc11f76dad53243a84439f /base/base.gyp | |
| parent | e91d532339c854ff0a082c6562a519647524fa66 (diff) | |
| download | chromium_src-d0767cb54b2b5ee4d9cf00b3ee0fa585826b4036.zip chromium_src-d0767cb54b2b5ee4d9cf00b3ee0fa585826b4036.tar.gz chromium_src-d0767cb54b2b5ee4d9cf00b3ee0fa585826b4036.tar.bz2 | |
Separate out some more ICU from base and into base/i18n.
This moves string_util_icu. I moved the number formatting function into
base/i18n/number_formatting and just removed the other function in
string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places
and isn't actually helpful (and the fact that it round-trips through UTF-16 is
better for the caller to see).
This takes out the sorting from the FileEnumerator. The comment says the
sorting is not guaranteed. I moved it into file_util_icu as a standalone
function for callers of FileEnumerator to call manually if they need sorted
results. I modified the directory lister to use this sorting instead, and filed
a bug on doing more optimal JS-based sorting.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/267001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gyp')
| -rw-r--r-- | base/base.gyp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/base/base.gyp b/base/base.gyp index 41108dd..570e9f0 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -121,7 +121,6 @@ 'file_path.h', 'file_util.cc', 'file_util.h', - 'file_util_icu.cc', 'file_util_linux.cc', 'file_util_mac.mm', 'file_util_posix.cc', @@ -141,8 +140,12 @@ 'hmac_mac.cc', 'hmac_nss.cc', 'hmac_win.cc', + 'i18n/file_util_icu.cc', + 'i18n/file_util_icu.h', 'i18n/icu_string_conversions.cc', 'i18n/icu_string_conversions.h', + 'i18n/number_formatting.cc', + 'i18n/number_formatting.h', 'iat_patch.cc', 'iat_patch.h', 'icu_util.cc', @@ -284,7 +287,6 @@ 'string_tokenizer.h', 'string_util.cc', 'string_util.h', - 'string_util_icu.cc', 'string_util_win.h', 'sys_info.h', 'sys_info_chromeos.cc', @@ -582,6 +584,7 @@ 'histogram_unittest.cc', 'hmac_unittest.cc', 'id_map_unittest.cc', + 'i18n/file_util_icu_unittest.cc', 'json_reader_unittest.cc', 'json_writer_unittest.cc', 'lazy_instance_unittest.cc', |