diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-16 03:46:05 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-16 03:46:05 +0000 |
| commit | ce0e7246e92f2da8e6b865dd51ae626f9867ca4f (patch) | |
| tree | 8181f26fbe349c35ff37a9ae837603c3f11be7f8 /base/base.gyp | |
| parent | 21e74460f5b7cfe6f622557b20d40eecf3b8e98b (diff) | |
| download | chromium_src-ce0e7246e92f2da8e6b865dd51ae626f9867ca4f.zip chromium_src-ce0e7246e92f2da8e6b865dd51ae626f9867ca4f.tar.gz chromium_src-ce0e7246e92f2da8e6b865dd51ae626f9867ca4f.tar.bz2 | |
Move the windows-specific scoped_* stuff from base to base/win and in the base::win namespace.
This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch.
This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there.
I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3781009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gyp')
| -rw-r--r-- | base/base.gyp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/base/base.gyp b/base/base.gyp index d6245ca..dee0040 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -124,12 +124,9 @@ 'rand_util_unittest.cc', 'ref_counted_unittest.cc', 'registry_unittest.cc', - 'scoped_bstr_win_unittest.cc', - 'scoped_comptr_win_unittest.cc', 'scoped_native_library_unittest.cc', 'scoped_ptr_unittest.cc', 'scoped_temp_dir_unittest.cc', - 'scoped_variant_win_unittest.cc', 'sha1_unittest.cc', 'sha2_unittest.cc', 'shared_memory_unittest.cc', @@ -168,6 +165,9 @@ 'watchdog_unittest.cc', 'weak_ptr_unittest.cc', 'win_util_unittest.cc', + 'win/scoped_bstr_unittest.cc', + 'win/scoped_comptr_unittest.cc', + 'win/scoped_variant_unittest.cc', 'worker_pool_unittest.cc', ], 'include_dirs': [ @@ -213,6 +213,9 @@ 'file_descriptor_shuffle_unittest.cc', ], }, { # OS != "win" + 'sources/': [ + ['exclude', '^win/'], + ], 'sources!': [ 'event_trace_consumer_win_unittest.cc', 'event_trace_controller_win_unittest.cc', |