diff options
| author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-09 23:52:20 +0000 |
|---|---|---|
| committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-09 23:52:20 +0000 |
| commit | d8617a6ad0d531e8ad63298f7cd4a091b78aa43e (patch) | |
| tree | e60489d36fcbdf6f580e7c4cd715f2a085d5b56b /base/base.gyp | |
| parent | a36804546751df937333345b7a27b4ef8d60b67d (diff) | |
| download | chromium_src-d8617a6ad0d531e8ad63298f7cd4a091b78aa43e.zip chromium_src-d8617a6ad0d531e8ad63298f7cd4a091b78aa43e.tar.gz chromium_src-d8617a6ad0d531e8ad63298f7cd4a091b78aa43e.tar.bz2 | |
Add logging macros that automatically append the last system error in string form.
Also add thread-safe, portable variants for strerror() and strerror_r() on POSIX so that existing error logging code that calls strerror() for something other than LOG, LOG_IF, or CHECK can be changed to use safe versions too. After this CL I will eliminate all unsafe uses of strerror() in our code.
TEST=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests); trybots for Win, Mac, and Linux 32-bit; built locally for Linux 32-bit and 64-bit and tested base_unittests and also running Chromium itself; wrote the upcoming CL that switches strerror() calls to use PLOG and verified that it builds and works for both Linux 32-bit and Linux 64-bit; lint
BUG=none
Review URL: http://codereview.chromium.org/265052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28632 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gyp')
| -rw-r--r-- | base/base.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/base/base.gyp b/base/base.gyp index 09dca2b..61f5e3c 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -250,6 +250,8 @@ 'registry.h', 'resource_util.cc', 'resource_util.h', + 'safe_strerror_posix.cc', + 'safe_strerror_posix.h', 'scoped_bstr_win.cc', 'scoped_bstr_win.h', 'scoped_cftyperef.h', |