diff options
| author | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-08 22:31:50 +0000 |
|---|---|---|
| committer | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-08 22:31:50 +0000 |
| commit | fc214c084a4c358e915fa84a5b21546d639f3037 (patch) | |
| tree | 168a37e24aa45cebaf2e8c21d72cd45488da9ffd /base/base.gypi | |
| parent | d7f12169f5e72e1065be958179a5686829d8be6e (diff) | |
| download | chromium_src-fc214c084a4c358e915fa84a5b21546d639f3037.zip chromium_src-fc214c084a4c358e915fa84a5b21546d639f3037.tar.gz chromium_src-fc214c084a4c358e915fa84a5b21546d639f3037.tar.bz2 | |
Revert 210423 "base: Make SequencedWorkerPool issue globally uni..."
Speculative revert for failing PageCyclerTest.FailProvisionalLoads on
linux_clang.
> base: Make SequencedWorkerPool issue globally unique SequenceTokens.
>
> SequencedWorkerPool currently issues SequenceTokens out of an internal member counter. This means that two different SequencedWorkerPool instances can issue identical SequenceTokens, which mucks up any attempt to distinguish sequences using only SequenceTokens.
>
> This change makes the SequenceTokens issued from an StaticAtomicSequenceNumber, which is globally shared amongst all SequencedWorkerPools.
>
> This change also makes the SequencedWorkerPool included in the nacl_untrusted builds, as it is needed for SequenceChecker and WeakPtr to work correctly. It previously was excluded because it used base/metrics. I've #ifdefed the base/metrics usage out for nacl.
>
> This issue is a spinoff and pre-requisite of issue 18501008: Make WeakPtr use SequenceChecker instead of ThreadChecker.
>
> R=akalin,darin
> BUG=165590
>
> Review URL: https://chromiumcodereview.appspot.com/18650006
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/18271011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210433 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gypi')
| -rw-r--r-- | base/base.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/base.gypi b/base/base.gypi index fc7cf04..f3b16d8 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -701,6 +701,7 @@ 'scoped_native_library.cc', 'files/scoped_temp_dir.cc', 'sys_info_posix.cc', + 'threading/sequenced_worker_pool.cc', 'third_party/dynamic_annotations/dynamic_annotations.c', ], 'sources/': [ |