diff options
| author | avi <avi@chromium.org> | 2014-10-24 11:57:32 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-24 18:58:03 +0000 |
| commit | 1059684e79cf4e7b2de1b3f282ac5adfd0d4a166 (patch) | |
| tree | d0b009d0bd93b8967c80cdcaa8c4d3a7ee5cdb01 /base/base.gypi | |
| parent | 11f13546fd3ee3d53921c23861bf970bd2bb6428 (diff) | |
| download | chromium_src-1059684e79cf4e7b2de1b3f282ac5adfd0d4a166.zip chromium_src-1059684e79cf4e7b2de1b3f282ac5adfd0d4a166.tar.gz chromium_src-1059684e79cf4e7b2de1b3f282ac5adfd0d4a166.tar.bz2 | |
Revert of Add browser-wide discardable memory implementation. (patchset #23 id:910001 of https://codereview.chromium.org/531343002/)
Reason for revert:
Causes compile error.
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/39232
../../base/memory/discardable_shared_memory.cc:208:5:error: ignoring return value of function declared with warn_unused_result attribute [-Werror,-Wunused-result]
ftruncate(handle.fd, sizeof(SharedState));
^~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Original issue's description:
> Add browser-wide discardable memory implementation.
>
> This provides a platform agnostic implementation of discardable
> memory based on shared memory. Managment of discardable memory is
> moved to the browser process instead of being local to each renderer.
> This provides much better control over chromium's total discardable
> memory usage.
>
> A round-trip to the browser IO thread is necessary for a renderer
> to allocate a new discardable memory segment but the cost of this
> can be reduced by maintaining free lists on the renderer side and
> have discardable memory instances share the same discardable
> memory segment. The implementation of this optimization is left as
> a follow up.
>
> Note: while the general implementation is platform agnostic, it
> takes advantage of the ftruncate syscall available on Posix
> platforms. This syscall makes it possible to release discardable
> memory segments immediately to the OS from the browser process.
>
> BUG=381178,400423,422953
> TEST=base_unittests --gtest_filter=DiscardableMemoryTests*, base_unittests --gtest_filter=DiscardableSharedMemory.*, content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerTest.*
>
> Committed: https://crrev.com/2ac2d83d86b0206b908eea0d6e1002850d238a88
> Cr-Commit-Position: refs/heads/master@{#301152}
TBR=skuhne@chromium.org,rmcilroy@chromium.org,danakj@chromium.org,rsesek@chromium.org,nasko@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381178,400423,422953
Review URL: https://codereview.chromium.org/678603003
Cr-Commit-Position: refs/heads/master@{#301156}
Diffstat (limited to 'base/base.gypi')
| -rw-r--r-- | base/base.gypi | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/base/base.gypi b/base/base.gypi index 9542529..2dfde09 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -332,13 +332,7 @@ 'memory/discardable_memory_mac.cc', 'memory/discardable_memory_manager.cc', 'memory/discardable_memory_manager.h', - 'memory/discardable_memory_shmem.cc', - 'memory/discardable_memory_shmem.h', - 'memory/discardable_memory_shmem_allocator.cc', - 'memory/discardable_memory_shmem_allocator.h', 'memory/discardable_memory_win.cc', - 'memory/discardable_shared_memory.cc', - 'memory/discardable_shared_memory.h', 'memory/linked_ptr.h', 'memory/manual_constructor.h', 'memory/memory_pressure_listener.cc', |