diff options
author | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 09:51:40 +0000 |
---|---|---|
committer | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 09:51:40 +0000 |
commit | 289f5a7870a3f1e5ed7b465556125515a6e474b0 (patch) | |
tree | 6c2569a80bd165d905f7c84cc04798dda9fb0f60 /base/base64.cc | |
parent | dc20613ba3e16cf90dc862cdd27c989a1388a6b0 (diff) | |
download | chromium_src-289f5a7870a3f1e5ed7b465556125515a6e474b0.zip chromium_src-289f5a7870a3f1e5ed7b465556125515a6e474b0.tar.gz chromium_src-289f5a7870a3f1e5ed7b465556125515a6e474b0.tar.bz2 |
Revert 93365 - it broke on Chrome OS
Added RefCountedString, as this is what many RefCountedMemory users seem to want
Made data member of RefCountedBytes private, as per style guide
Changed base64 APIs to accept StringPiece, as it's sometimes better and never worse than string.
BUG=None
TEST=All existing tests pass. Extended ref_counted_memory_unittests
Review URL: http://codereview.chromium.org/7397021
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/7471033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93367 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base64.cc')
-rw-r--r-- | base/base64.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/base64.cc b/base/base64.cc index 62bd12d..56a577d 100644 --- a/base/base64.cc +++ b/base/base64.cc @@ -8,7 +8,7 @@ namespace base { -bool Base64Encode(const StringPiece& input, std::string* output) { +bool Base64Encode(const std::string& input, std::string* output) { std::string temp; temp.resize(modp_b64_encode_len(input.size())); // makes room for null byte @@ -23,7 +23,7 @@ bool Base64Encode(const StringPiece& input, std::string* output) { return true; } -bool Base64Decode(const StringPiece& input, std::string* output) { +bool Base64Decode(const std::string& input, std::string* output) { std::string temp; temp.resize(modp_b64_decode_len(input.size())); |