diff options
| author | vadimt@chromium.org <vadimt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-11 01:48:50 +0000 |
|---|---|---|
| committer | vadimt@chromium.org <vadimt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-11 01:48:50 +0000 |
| commit | 33fca12d265b8129e6cff8fc1fc9ad7b34a19bab (patch) | |
| tree | ef737a2c12192c512ea7e05460c758e42200590a /base/base64.h | |
| parent | 5cddcd140cbe8fc9a8e10e67142cee75dc99684b (diff) | |
| download | chromium_src-33fca12d265b8129e6cff8fc1fc9ad7b34a19bab.zip chromium_src-33fca12d265b8129e6cff8fc1fc9ad7b34a19bab.tar.gz chromium_src-33fca12d265b8129e6cff8fc1fc9ad7b34a19bab.tar.bz2 | |
Revert 239921 "Revert 239759 "The comment in base64.h implies th..."
*****************
Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess.
*****************
> Revert 239759 "The comment in base64.h implies that base::Base64..."
>
> > The comment in base64.h implies that base::Base64Encode() can return false, but
> > this cannot happen in practice. Fix the comment.
> >
> > The implementation of Base64Encode() attempts to check for the return value
> > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> > value. Remove the check.
> >
> > Remove unneeded integer cast.
> >
> > Change the return type to void.
> >
> > BUG=323357
> > TEST=base_unittests, compile all
> > TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/86913002
>
> TBR=ricea@chromium.org
>
> Review URL: https://codereview.chromium.org/101113004
TBR=vadimt@chromium.org
Review URL: https://codereview.chromium.org/111883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239944 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base64.h')
| -rw-r--r-- | base/base64.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/base/base64.h b/base/base64.h index cc78edc..43d8f76 100644 --- a/base/base64.h +++ b/base/base64.h @@ -12,9 +12,8 @@ namespace base { -// Encodes the input string in base64. Returns true if successful and false -// otherwise. The output string is only modified if successful. -BASE_EXPORT bool Base64Encode(const StringPiece& input, std::string* output); +// Encodes the input string in base64. +BASE_EXPORT void Base64Encode(const StringPiece& input, std::string* output); // Decodes the base64 input string. Returns true if successful and false // otherwise. The output string is only modified if successful. |