diff options
| author | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 11:55:10 +0000 |
|---|---|---|
| committer | ricea@chromium.org <ricea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 11:55:10 +0000 |
| commit | 0553072d237ad2b977e948591de3f87eee536a9c (patch) | |
| tree | 58b462d22b2342db07c041ac8abaf061e671d1e5 /base/base64_unittest.cc | |
| parent | 9377d2ad77c6d7ee0190c90544eaed0ff0c7fc9c (diff) | |
| download | chromium_src-0553072d237ad2b977e948591de3f87eee536a9c.zip chromium_src-0553072d237ad2b977e948591de3f87eee536a9c.tar.gz chromium_src-0553072d237ad2b977e948591de3f87eee536a9c.tar.bz2 | |
The comment in base64.h implies that base::Base64Encode() can return false, but
this cannot happen in practice. Fix the comment.
The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.
Remove unneeded integer cast.
Change the return type to void.
BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/86913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239759 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base64_unittest.cc')
| -rw-r--r-- | base/base64_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/base/base64_unittest.cc b/base/base64_unittest.cc index 9a5dd81..9b23194 100644 --- a/base/base64_unittest.cc +++ b/base/base64_unittest.cc @@ -16,8 +16,7 @@ TEST(Base64Test, Basic) { std::string decoded; bool ok; - ok = Base64Encode(kText, &encoded); - EXPECT_TRUE(ok); + Base64Encode(kText, &encoded); EXPECT_EQ(kBase64Text, encoded); ok = Base64Decode(encoded, &decoded); |