diff options
| author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-26 16:22:50 +0000 |
|---|---|---|
| committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-26 16:22:50 +0000 |
| commit | 6a341fbb4fa4651ea5d60ce8aa57e5fabe3da375 (patch) | |
| tree | 1062e8ae71f9d3a15421809847e6b0208bde8ad0 /base/bind_unittest.cc | |
| parent | e93fd55e815c0004672e0a7621fcd617b8196035 (diff) | |
| download | chromium_src-6a341fbb4fa4651ea5d60ce8aa57e5fabe3da375.zip chromium_src-6a341fbb4fa4651ea5d60ce8aa57e5fabe3da375.tar.gz chromium_src-6a341fbb4fa4651ea5d60ce8aa57e5fabe3da375.tar.bz2 | |
Add COMPILE_ASSERT to ensure the result of Bind matches the Callback's type.
Required because we abstract the storage of the funciton pointer out using
a reinterpret_cast to reduce template bloat. This effectively readds the
failure that would have happened had we stored the function pointer directly
in the template class.
BUG=86008
TEST=new unittests.
Review URL: http://codereview.chromium.org/7241015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90525 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/bind_unittest.cc')
| -rw-r--r-- | base/bind_unittest.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/base/bind_unittest.cc b/base/bind_unittest.cc index d57f3d0..333512a 100644 --- a/base/bind_unittest.cc +++ b/base/bind_unittest.cc @@ -677,6 +677,8 @@ TEST_F(BindTest, NoCompile) { // Callback<int(void)> weak_ptr_with_non_void_return_type = // Bind(&NoRef::IntMethod0, weak_factory.GetWeakPtr()); + // - Bind result cannot be assigned to Callbacks with a mismatching type. + // Closure callback_mismatches_bind_type = Bind(&VoidPolymorphic1<int>); } #if defined(OS_WIN) |