summaryrefslogtreecommitdiffstats
path: root/base/bind_unittest.cc
diff options
context:
space:
mode:
authorhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-15 10:52:11 +0000
committerhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-15 10:52:11 +0000
commitf3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5 (patch)
tree1d7a6fc34e066dcbf9d2bc01af2244f72cbd78a7 /base/bind_unittest.cc
parentd443be6fdfe17ca4f3ff1843ded362ff0cd01096 (diff)
downloadchromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.zip
chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.gz
chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.bz2
Add missing, and remove unnecessary, 'explicit' from constructors. (base/)
The style guide says that constructors which can be called with one argument should be explicit. For constructors which cannot be called with exactly one argument, there is no reason to mark them explicit. BUG=163357 Review URL: https://chromiumcodereview.appspot.com/11779022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/bind_unittest.cc')
-rw-r--r--base/bind_unittest.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/base/bind_unittest.cc b/base/bind_unittest.cc
index 1d808a6..5ca67e9 100644
--- a/base/bind_unittest.cc
+++ b/base/bind_unittest.cc
@@ -106,7 +106,7 @@ class CopyCounter {
}
// Probing for copies from coercion.
- CopyCounter(const DerivedCopyCounter& other)
+ explicit CopyCounter(const DerivedCopyCounter& other)
: copies_(other.copies_),
assigns_(other.assigns_) {
(*copies_)++;
@@ -766,7 +766,7 @@ TEST_F(BindTest, ArgumentCopies) {
DerivedCopyCounter dervied(&copies, &assigns);
Callback<void(CopyCounter)> coerce_cb =
Bind(&VoidPolymorphic1<CopyCounter>);
- coerce_cb.Run(dervied);
+ coerce_cb.Run(CopyCounter(dervied));
EXPECT_GE(2, copies);
EXPECT_EQ(0, assigns);
}