summaryrefslogtreecommitdiffstats
path: root/base/callback_list.h
diff options
context:
space:
mode:
authordavidben <davidben@chromium.org>2015-10-30 13:42:07 -0700
committerCommit bot <commit-bot@chromium.org>2015-10-30 20:42:48 +0000
commitf126cb2007e7d20764aeb4d4a41f3061010d4ee4 (patch)
treece2a030922c806afaecd42d1744c8aaebdc5972d /base/callback_list.h
parent233d38f9d8300b4078789bfe303c022e159335a7 (diff)
downloadchromium_src-f126cb2007e7d20764aeb4d4a41f3061010d4ee4.zip
chromium_src-f126cb2007e7d20764aeb4d4a41f3061010d4ee4.tar.gz
chromium_src-f126cb2007e7d20764aeb4d4a41f3061010d4ee4.tar.bz2
Only signal the removal callback once in CallbackList::Compact.
Noticed this typo on a whim. Right now it signals it once for every registered callback (removed or not) after the first removed one. BUG=none Review URL: https://codereview.chromium.org/1420053007 Cr-Commit-Position: refs/heads/master@{#357188}
Diffstat (limited to 'base/callback_list.h')
-rw-r--r--base/callback_list.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/base/callback_list.h b/base/callback_list.h
index aeed5f1..5f263f8 100644
--- a/base/callback_list.h
+++ b/base/callback_list.h
@@ -185,10 +185,10 @@ class CallbackListBase {
} else {
++it;
}
-
- if (updated && !removal_callback_.is_null())
- removal_callback_.Run();
}
+
+ if (updated && !removal_callback_.is_null())
+ removal_callback_.Run();
}
private: