diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
| commit | da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0 (patch) | |
| tree | 5e8bfb0503ab08a672054fa34e04ef7cce3d0d2f /base/command_line.cc | |
| parent | 6c293a7baba7aa1d998e2680492246f239a7015d (diff) | |
| download | chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.zip chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.gz chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.bz2 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/command_line.cc')
| -rw-r--r-- | base/command_line.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/base/command_line.cc b/base/command_line.cc index 22977af..0237ffe 100644 --- a/base/command_line.cc +++ b/base/command_line.cc @@ -268,8 +268,8 @@ std::string CommandLine::GetSwitchValueASCII( const std::string& switch_string) const { StringType value = GetSwitchValueNative(switch_string); if (!IsStringASCII(value)) { - LOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII."; - return ""; + DLOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII."; + return std::string(); } #if defined(OS_WIN) return WideToASCII(value); @@ -394,8 +394,8 @@ void CommandLine::ParseFromString(const std::wstring& command_line) { wchar_t** args = NULL; args = ::CommandLineToArgvW(command_line_string.c_str(), &num_args); - PLOG_IF(FATAL, !args) << "CommandLineToArgvW failed on command line: " << - command_line; + DPLOG_IF(FATAL, !args) << "CommandLineToArgvW failed on command line: " + << command_line; InitFromArgv(num_args, args); LocalFree(args); } |