diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 01:26:24 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 01:26:24 +0000 |
| commit | 26667b335d5f403792a621524e5e6ccfa1a493ad (patch) | |
| tree | 98c412dc76270e3dd248d54f24bdca402c03ccbe /base/condition_variable_unittest.cc | |
| parent | 4760e5c7b54e1cd873a485ee1563144b36693a1b (diff) | |
| download | chromium_src-26667b335d5f403792a621524e5e6ccfa1a493ad.zip chromium_src-26667b335d5f403792a621524e5e6ccfa1a493ad.tar.gz chromium_src-26667b335d5f403792a621524e5e6ccfa1a493ad.tar.bz2 | |
Typo in test is exposed as a flaky test
I recently updated these tests to reduce flakiness, but there
was a typo in one line of the update.
Since tasks were run serially, the total time to run N-1 tasks should
be greater than or EQUAL to the task durtaion, times N-1.
r=mark
Review URL: http://codereview.chromium.org/74003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13640 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/condition_variable_unittest.cc')
| -rw-r--r-- | base/condition_variable_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/condition_variable_unittest.cc b/base/condition_variable_unittest.cc index 57e20ae..3266dd9 100644 --- a/base/condition_variable_unittest.cc +++ b/base/condition_variable_unittest.cc @@ -231,7 +231,7 @@ TEST_F(ConditionVariableTest, MultiThreadConsumerTest) { queue.no_more_tasks()->Wait(); // The last of the tasks *might* still be running, but... all but one should // be done by now, since tasks are being done serially. - EXPECT_LT(queue.GetWorkTime().InMilliseconds() * (kTaskCount - 1), + EXPECT_LE(queue.GetWorkTime().InMilliseconds() * (kTaskCount - 1), (base::Time::Now() - start_time).InMilliseconds()); EXPECT_EQ(1, queue.GetNumThreadsTakingAssignments()); |