diff options
author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 00:45:04 +0000 |
---|---|---|
committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 00:45:04 +0000 |
commit | d02f41640fbc99ad55084a6b232285c3a44a9c1f (patch) | |
tree | 6256343ce7e755a920fcf779611fc3a2c8ba6ac5 /base/crypto | |
parent | fb804132c4cd3ad50926a21a148954f67ac656bb (diff) | |
download | chromium_src-d02f41640fbc99ad55084a6b232285c3a44a9c1f.zip chromium_src-d02f41640fbc99ad55084a6b232285c3a44a9c1f.tar.gz chromium_src-d02f41640fbc99ad55084a6b232285c3a44a9c1f.tar.bz2 |
Disable the negative test cases in the test
SignatureVerifierTest.BasicTest when running inside Purify
because Purify disables digital signature verification.
R=erikkay
BUG=10031
Review URL: http://codereview.chromium.org/69010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13724 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/crypto')
-rw-r--r-- | base/crypto/signature_verifier_unittest.cc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/base/crypto/signature_verifier_unittest.cc b/base/crypto/signature_verifier_unittest.cc index 3317601..e28395f 100644 --- a/base/crypto/signature_verifier_unittest.cc +++ b/base/crypto/signature_verifier_unittest.cc @@ -238,7 +238,14 @@ TEST(SignatureVerifierTest, BasicTest) { EXPECT_TRUE(ok); verifier.VerifyUpdate(bad_tbs_certificate, sizeof(bad_tbs_certificate)); ok = verifier.VerifyFinal(); + + // Purify disables digital signature verification, causing the Windows + // CryptoAPI function CryptVerifySignature to always succeed. So we can't + // check the signature verification results of the negative tests when + // running inside Purify. See http://crbug.com/10031. +#ifndef PURIFY EXPECT_FALSE(ok); +#endif // Test 4: verify a bad signature. uint8 bad_signature[sizeof(signature)]; @@ -254,6 +261,8 @@ TEST(SignatureVerifierTest, BasicTest) { if (ok) { verifier.VerifyUpdate(tbs_certificate, sizeof(tbs_certificate)); ok = verifier.VerifyFinal(); +#ifndef PURIFY EXPECT_FALSE(ok); +#endif } } |