diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 20:41:28 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 20:41:28 +0000 |
| commit | 63e39a28e492e8f9a10d05cd970da2a1d539c0f3 (patch) | |
| tree | 60271c1be8eceb87e0f8206d18f65a88b5a3d286 /base/debug/debug_on_start_win.h | |
| parent | 8c01b7f619cb7a166c2b78269aed9f2333ad89c9 (diff) | |
| download | chromium_src-63e39a28e492e8f9a10d05cd970da2a1d539c0f3.zip chromium_src-63e39a28e492e8f9a10d05cd970da2a1d539c0f3.tar.gz chromium_src-63e39a28e492e8f9a10d05cd970da2a1d539c0f3.tar.bz2 | |
Add COMPONENT_BUILD global define.
This avoids the need to define FOO_DLL macros for each project that we wish to
optionally build as a DLL (when component=="shared_library"). This in turn
means that we do not need direct_dependent_settings to define FOO_DLL, and that
means that we don't need to update projects to convert transitive dependencies
into explicit dependencies. This makes the component build more consistent
with the static build.
An alternative would be to use all_dependent_settings, but I feel that the
global approach is simpler as it creates less repetition in each target
definition for components.
A side-effect of this change is that I needed to make base_nacl_win64 be a
shared_library in the component build.
R=rvargas,bradnelson,evan
Review URL: http://codereview.chromium.org/7344022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/debug/debug_on_start_win.h')
| -rw-r--r-- | base/debug/debug_on_start_win.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/debug/debug_on_start_win.h b/base/debug/debug_on_start_win.h index 4a5c120..86d4721 100644 --- a/base/debug/debug_on_start_win.h +++ b/base/debug/debug_on_start_win.h @@ -27,7 +27,7 @@ namespace debug { // There is no way for this code, as currently implemented, to work across DLLs. // TODO(rvargas): It looks like we really don't use this code, at least not for // Chrome. Figure out if it's really worth implementing something simpler. -#if !defined(BASE_DLL) +#if !defined(COMPONENT_BUILD) // Debug on start functions and data. class DebugOnStart { @@ -74,7 +74,7 @@ DECLSPEC_SELECTANY DebugOnStart::PIFV debug_on_start = &DebugOnStart::Init; #endif // _WIN64 -#endif // defined(BASE_DLL) +#endif // defined(COMPONENT_BUILD) } // namespace debug } // namespace base |