diff options
| author | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-19 10:31:00 +0000 |
|---|---|---|
| committer | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-19 10:31:00 +0000 |
| commit | a5b7b7d090670613f099b13f2edd341ed0ae0267 (patch) | |
| tree | d5fc321019ad2246419edf9700e3a9abdafb2940 /base/debug/leak_annotations.h | |
| parent | fd1cc5a88f528d58d311b24bf2b1b9b437369b30 (diff) | |
| download | chromium_src-a5b7b7d090670613f099b13f2edd341ed0ae0267.zip chromium_src-a5b7b7d090670613f099b13f2edd341ed0ae0267.tar.gz chromium_src-a5b7b7d090670613f099b13f2edd341ed0ae0267.tar.bz2 | |
Re-land http://codereview.chromium.org/6869009 (except for the suppressions)
Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark
heap allocated objects as intentionally leaked ones.
Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked.
Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky.
The previous commit broke the build on Linux Heapcheck, but looks like the problem has gone now.
TBR=jar,willchan
BUG=79322
Review URL: http://codereview.chromium.org/7048005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85898 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/debug/leak_annotations.h')
| -rw-r--r-- | base/debug/leak_annotations.h | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/base/debug/leak_annotations.h b/base/debug/leak_annotations.h index e1086fe..2d636f2 100644 --- a/base/debug/leak_annotations.h +++ b/base/debug/leak_annotations.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -18,10 +18,22 @@ #define ANNOTATE_SCOPED_MEMORY_LEAK \ HeapLeakChecker::Disabler heap_leak_checker_disabler +// Annotate an object pointer as referencing a leaky object. This object and all +// the heap objects referenced by it will be ignored by the heap checker. +// +// X should be referencing an active allocated object. If it is not, the +// annotation will be ignored. +// No object should be annotated with ANNOTATE_SCOPED_MEMORY_LEAK twice. +// Once an object is annotated with ANNOTATE_SCOPED_MEMORY_LEAK, it cannot be +// deleted. +#define ANNOTATE_LEAKING_OBJECT_PTR(X) \ + HeapLeakChecker::IgnoreObject(X) + #else // If tcmalloc is not used, the annotations should be no-ops. #define ANNOTATE_SCOPED_MEMORY_LEAK +#define ANNOTATE_LEAKING_OBJECT_PTR(X) #endif |