diff options
| author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-04 23:00:10 +0000 |
|---|---|---|
| committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-04 23:00:10 +0000 |
| commit | 864b558217c75dbdebea9db3568056292d4cd274 (patch) | |
| tree | 06bd9f240065ed47fab9ff415ae4cd49f21facf1 /base/debug/trace_event.h | |
| parent | 8c9e61a02aad4d8baa0f75ae7ac2f2f1963fffd6 (diff) | |
| download | chromium_src-864b558217c75dbdebea9db3568056292d4cd274.zip chromium_src-864b558217c75dbdebea9db3568056292d4cd274.tar.gz chromium_src-864b558217c75dbdebea9db3568056292d4cd274.tar.bz2 | |
This CL add a GetInstance() method to singleton classes instead of relying on the callers to use Singleton<T>.
In some cases I have used the LazyInstance<T> pattern as that was simpler.
This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it.
I have selected all files under src/app and src/base which use Singleton<T> in this CL. Once this CL goes in I'll work on the rest of the files.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5527004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68300 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/debug/trace_event.h')
| -rw-r--r-- | base/debug/trace_event.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/base/debug/trace_event.h b/base/debug/trace_event.h index 49ba4bd..160bbc8 100644 --- a/base/debug/trace_event.h +++ b/base/debug/trace_event.h @@ -52,7 +52,7 @@ // Record that an event (of name, id) has begun. All BEGIN events should have // corresponding END events with a matching (name, id). #define TRACE_EVENT_BEGIN(name, id, extra) \ - Singleton<base::debug::TraceLog>::get()->Trace( \ + base::debug::TraceLog::GetInstance()->Trace( \ name, \ base::debug::TraceLog::EVENT_BEGIN, \ reinterpret_cast<const void*>(id), \ @@ -63,7 +63,7 @@ // Record that an event (of name, id) has ended. All END events should have // corresponding BEGIN events with a matching (name, id). #define TRACE_EVENT_END(name, id, extra) \ - Singleton<base::debug::TraceLog>::get()->Trace( \ + base::debug::TraceLog::GetInstance()->Trace( \ name, \ base::debug::TraceLog::EVENT_END, \ reinterpret_cast<const void*>(id), \ @@ -73,7 +73,7 @@ // Record that an event (of name, id) with no duration has happened. #define TRACE_EVENT_INSTANT(name, id, extra) \ - Singleton<base::debug::TraceLog>::get()->Trace( \ + base::debug::TraceLog::GetInstance()->Trace( \ name, \ base::debug::TraceLog::EVENT_INSTANT, \ reinterpret_cast<const void*>(id), \ @@ -96,6 +96,8 @@ class TraceLog { EVENT_INSTANT }; + static TraceLog* GetInstance(); + // Is tracing currently enabled. static bool IsTracing(); // Start logging trace events. |