diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-06 21:44:33 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-06 21:44:33 +0000 |
| commit | 8fc5618676949b8bebd39f584bf193314b5eb566 (patch) | |
| tree | 98b37da8c3b10c04087589c49e56d114bd7d504c /base/debug | |
| parent | 430248b7a336509b94b30df5fe6e982d9efb43f1 (diff) | |
| download | chromium_src-8fc5618676949b8bebd39f584bf193314b5eb566.zip chromium_src-8fc5618676949b8bebd39f584bf193314b5eb566.tar.gz chromium_src-8fc5618676949b8bebd39f584bf193314b5eb566.tar.bz2 | |
This is an ordered set tailored to GN's (simple) needs.
This vector is now used to store all config lists. Previously the code did a bunch of work to uniquify configs at certain points (in target.cc) but direct_dependent_configs still ended up with lots of duplicates.
Before this patch the chrome/browser target has 41098 direct_dependent_configs, and after this patch it has 7. Apparently we were also spending a lot of time on these. Before this patch Windows wall clock time was 1031ms, and after this patch it's 831ms. Linux was 834ms before and 593ms after.
Also fix minor build issues in base I noticed while working on this.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/26537002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287865 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/debug')
| -rw-r--r-- | base/debug/stack_trace_win.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/debug/stack_trace_win.cc b/base/debug/stack_trace_win.cc index 6393db3..8df6fc6 100644 --- a/base/debug/stack_trace_win.cc +++ b/base/debug/stack_trace_win.cc @@ -263,7 +263,7 @@ void StackTrace::OutputToStream(std::ostream* os) const { if (error != ERROR_SUCCESS) { (*os) << "Error initializing symbols (" << error << "). Dumping unresolved backtrace:\n"; - for (int i = 0; (i < count_) && os->good(); ++i) { + for (size_t i = 0; (i < count_) && os->good(); ++i) { (*os) << "\t" << trace_[i] << "\n"; } } else { |