diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:12:03 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:12:03 +0000 |
| commit | 095af31fb984c397ab4481322341df38d232056e (patch) | |
| tree | 0571ff8ea16106dc10840a4987296ba80d82d685 /base/debug_util_win.cc | |
| parent | 0c43e2cc628b10a6151c03e73aa6b35d280fbfb5 (diff) | |
| download | chromium_src-095af31fb984c397ab4481322341df38d232056e.zip chromium_src-095af31fb984c397ab4481322341df38d232056e.tar.gz chromium_src-095af31fb984c397ab4481322341df38d232056e.tar.bz2 | |
Not calling debugbreak when SymInitialize fails with "invalid parameter".
TEST=This could cause one failing unit test to prevent others from being run.
BUG=none
Review URL: http://codereview.chromium.org/174555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24789 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/debug_util_win.cc')
| -rw-r--r-- | base/debug_util_win.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/base/debug_util_win.cc b/base/debug_util_win.cc index 3a7decd..08bfb41 100644 --- a/base/debug_util_win.cc +++ b/base/debug_util_win.cc @@ -164,8 +164,13 @@ class SymbolContext { if (SymInitialize(GetCurrentProcess(), NULL, TRUE)) { init_error_ = ERROR_SUCCESS; } else { - __debugbreak(); init_error_ = GetLastError(); + // TODO(awong): Handle error: SymInitialize can fail with + // ERROR_INVALID_PARAMETER. + // When it fails, we should not call debugbreak since it kills the current + // process (prevents future tests from running or kills the browser + // process). + DLOG(ERROR) << "SymInitialize failed: " << init_error_; } } |