diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-31 16:55:40 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-31 16:55:40 +0000 |
| commit | fc586c7e48d90dac7963906bf34c8f6382b55846 (patch) | |
| tree | 6357b8467129dbf4a5c970f1f7c4645da2bd9e51 /base/env_var.h | |
| parent | f44f18cee25dd55a14f1df0e99ac2c9e3e9214bc (diff) | |
| download | chromium_src-fc586c7e48d90dac7963906bf34c8f6382b55846.zip chromium_src-fc586c7e48d90dac7963906bf34c8f6382b55846.tar.gz chromium_src-fc586c7e48d90dac7963906bf34c8f6382b55846.tar.bz2 | |
Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API.
This reverts commit 7ed083f6d2b1b0a09c8bf9470386ba3e38f2feed.
It was reverted due to crbug.com/50663 started failing when I land this patch,
so I'm relanding it now again.
BUG=None
TEST=trybots
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3043018
Review URL: http://codereview.chromium.org/3076020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54451 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/env_var.h')
| -rw-r--r-- | base/env_var.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/base/env_var.h b/base/env_var.h index 9622e74..43d3fd6 100644 --- a/base/env_var.h +++ b/base/env_var.h @@ -20,11 +20,14 @@ extern const char kHome[]; } // namespace env_vars -// These are used to derive mocks for unittests. class EnvVarGetter { public: virtual ~EnvVarGetter(); + // Static factory method that returns the implementation that provide the + // appropriate platform-specific instance. + static EnvVarGetter* Create(); + // Gets an environment variable's value and stores it in |result|. // Returns false if the key is unset. virtual bool GetEnv(const char* variable_name, std::string* result) = 0; @@ -36,8 +39,8 @@ class EnvVarGetter { virtual bool SetEnv(const char* variable_name, const std::string& new_value) = 0; - // Create an instance of EnvVarGetter - static EnvVarGetter* Create(); + // Returns true on success, otherwise returns false. + virtual bool UnSetEnv(const char* variable_name) = 0; }; } // namespace base |