diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
| commit | bd635c097dfc689674d6b21c006850a7b07f23f4 (patch) | |
| tree | b9c8bdf9edc379e288c14f64e063e29efe7635c8 /base/event_trace_controller_win_unittest.cc | |
| parent | 19dc5d7922dc07b61c037ebbcc86f20dad27eab2 (diff) | |
| download | chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.zip chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.gz chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/event_trace_controller_win_unittest.cc')
| -rw-r--r-- | base/event_trace_controller_win_unittest.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/base/event_trace_controller_win_unittest.cc b/base/event_trace_controller_win_unittest.cc index f688d48..06170de 100644 --- a/base/event_trace_controller_win_unittest.cc +++ b/base/event_trace_controller_win_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // @@ -62,9 +62,9 @@ TEST(EtwTracePropertiesTest, Initialization) { EtwTraceProperties prop; EVENT_TRACE_PROPERTIES* p = prop.get(); - EXPECT_NE(0, p->Wnode.BufferSize); - EXPECT_EQ(0, p->Wnode.ProviderId); - EXPECT_EQ(0, p->Wnode.HistoricalContext); + EXPECT_NE(0u, p->Wnode.BufferSize); + EXPECT_EQ(0u, p->Wnode.ProviderId); + EXPECT_EQ(0u, p->Wnode.HistoricalContext); EXPECT_TRUE(kGuidNull == p->Wnode.Guid); EXPECT_EQ(0, p->Wnode.ClientContext); @@ -86,8 +86,8 @@ TEST(EtwTracePropertiesTest, Initialization) { EXPECT_EQ(0, p->LogBuffersLost); EXPECT_EQ(0, p->RealTimeBuffersLost); EXPECT_EQ(0, p->LoggerThreadId); - EXPECT_NE(0, p->LogFileNameOffset); - EXPECT_NE(0, p->LoggerNameOffset); + EXPECT_NE(0u, p->LogFileNameOffset); + EXPECT_NE(0u, p->LoggerNameOffset); } TEST(EtwTracePropertiesTest, Strings) { |