diff options
author | mlloyd@chromium.org <mlloyd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 22:46:33 +0000 |
---|---|---|
committer | mlloyd@chromium.org <mlloyd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 22:46:33 +0000 |
commit | 58d2d2dda2269eb7a40a4898592911d5f792ab02 (patch) | |
tree | c11e8d20c0b4eebea1e7213afb9abe7d279946bc /base/field_trial.h | |
parent | e7af596810a247bcee52927d3e4c6a02d38e9459 (diff) | |
download | chromium_src-58d2d2dda2269eb7a40a4898592911d5f792ab02.zip chromium_src-58d2d2dda2269eb7a40a4898592911d5f792ab02.tar.gz chromium_src-58d2d2dda2269eb7a40a4898592911d5f792ab02.tar.bz2 |
Have MakeName prepend the underscore to the field trial group name,
rather than having the field trial group name itself include the
underscore.
This will change the histogram names for only one field trial,
the CacheSizeGroup field trial, and I have got in touch with Mike
and Ricardo (who wrote that code); they confirmed that they don't
mind the name change.
Also updates the field trial unit tests to reflect the change,
and to make the use of the expected/actual arguments to the
unit test macros consistent
TEST=Unit tests pass.
BUG=None.
Review URL: http://codereview.chromium.org/3066036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55146 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/field_trial.h')
-rw-r--r-- | base/field_trial.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/field_trial.h b/base/field_trial.h index 9dba639..b1f0a07 100644 --- a/base/field_trial.h +++ b/base/field_trial.h @@ -34,8 +34,8 @@ // // process teardown, courtesy of their automatic registration in // // FieldTrialList. // scoped_refptr<FieldTrial> trial = new FieldTrial("MemoryExperiment", 1000); -// int group1 = trial->AppendGroup("_high_mem", 20); // 2% in _high_mem group. -// int group2 = trial->AppendGroup("_low_mem", 20); // 2% in _low_mem group. +// int group1 = trial->AppendGroup("high_mem", 20); // 2% in high_mem group. +// int group2 = trial->AppendGroup("low_mem", 20); // 2% in low_mem group. // // Take action depending of which group we randomly land in. // if (trial->group() == group1) // SetPruningAlgorithm(kType1); // Sample setting of browser state. @@ -125,7 +125,7 @@ class FieldTrial : public base::RefCounted<FieldTrial> { // This is empty of the trial is not in the experiment. const std::string name_; - // The maximu sum of all probabilities supplied, which corresponds to 100%. + // The maximum sum of all probabilities supplied, which corresponds to 100%. // This is the scaling factor used to adjust supplied probabilities. Probability divisor_; |