diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 02:28:16 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 02:28:16 +0000 |
| commit | cabe39c43a98b6b635951d5cb3649e061e36ea21 (patch) | |
| tree | c76282b5ed8452f490edbda9ed0a32bf364b5d6a /base/file_descriptor_shuffle.cc | |
| parent | ce716d859764f7a6e8ea0c79bbcd445d856f4da0 (diff) | |
| download | chromium_src-cabe39c43a98b6b635951d5cb3649e061e36ea21.zip chromium_src-cabe39c43a98b6b635951d5cb3649e061e36ea21.tar.gz chromium_src-cabe39c43a98b6b635951d5cb3649e061e36ea21.tar.bz2 | |
linux: check the return value passed through HANDLE_EINTR
A smarter compiler (clang) can notice that we were not using the return
values being passed through HANDLE_EINTR, which meant most frequently
that we were missing checking the return value of close().
Review URL: http://codereview.chromium.org/569003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37786 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_descriptor_shuffle.cc')
| -rw-r--r-- | base/file_descriptor_shuffle.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/base/file_descriptor_shuffle.cc b/base/file_descriptor_shuffle.cc index b26ea7f..e722a29 100644 --- a/base/file_descriptor_shuffle.cc +++ b/base/file_descriptor_shuffle.cc @@ -76,7 +76,8 @@ bool FileDescriptorTableInjection::Move(int src, int dest) { } void FileDescriptorTableInjection::Close(int fd) { - HANDLE_EINTR(close(fd)); + int ret = HANDLE_EINTR(close(fd)); + DPCHECK(ret == 0); } } // namespace base |