diff options
author | hayato@chromium.org <hayato@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-15 10:09:52 +0000 |
---|---|---|
committer | hayato@chromium.org <hayato@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-15 10:09:52 +0000 |
commit | 4fab4ace59c209a4f77ea39b1ad6e1d213b778f4 (patch) | |
tree | 8a54f9f9f1bcdbf8bb9bb38ec33cdb1a471067de /base/file_descriptor_shuffle_unittest.cc | |
parent | efd233d9b7831d1371594aee9434e5a684aa0c3a (diff) | |
download | chromium_src-4fab4ace59c209a4f77ea39b1ad6e1d213b778f4.zip chromium_src-4fab4ace59c209a4f77ea39b1ad6e1d213b778f4.tar.gz chromium_src-4fab4ace59c209a4f77ea39b1ad6e1d213b778f4.tar.bz2 |
Use ASSERT_EQ instead of EXPECT_EQ to avoid accessing invalid index in the following tests.
TEST=FileDescriptorsShuffleTest in base_unitest
BUG=None
Review URL: http://codereview.chromium.org/486029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34542 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_descriptor_shuffle_unittest.cc')
-rw-r--r-- | base/file_descriptor_shuffle_unittest.cc | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/base/file_descriptor_shuffle_unittest.cc b/base/file_descriptor_shuffle_unittest.cc index 981eed9..a4a703a 100644 --- a/base/file_descriptor_shuffle_unittest.cc +++ b/base/file_descriptor_shuffle_unittest.cc @@ -101,7 +101,7 @@ TEST(FileDescriptorShuffleTest, Simple1) { map.push_back(InjectionArc(0, 1, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(1u, tracer.actions().size()); + ASSERT_EQ(1u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); } @@ -112,7 +112,7 @@ TEST(FileDescriptorShuffleTest, Simple2) { map.push_back(InjectionArc(2, 3, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(2u, tracer.actions().size()); + ASSERT_EQ(2u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 2, 3)); } @@ -123,7 +123,7 @@ TEST(FileDescriptorShuffleTest, Simple3) { map.push_back(InjectionArc(0, 1, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(2u, tracer.actions().size()); + ASSERT_EQ(2u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::CLOSE, 0)); } @@ -135,7 +135,7 @@ TEST(FileDescriptorShuffleTest, Simple4) { map.push_back(InjectionArc(1, 1, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(2u, tracer.actions().size()); + ASSERT_EQ(2u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 10, 0)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::CLOSE, 10)); } @@ -147,7 +147,7 @@ TEST(FileDescriptorShuffleTest, Cycle) { map.push_back(InjectionArc(1, 0, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(4u, tracer.actions().size()); + ASSERT_EQ(4u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::DUPLICATE, kDuplicateBase, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 1)); @@ -162,7 +162,7 @@ TEST(FileDescriptorShuffleTest, CycleAndClose1) { map.push_back(InjectionArc(1, 0, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(4u, tracer.actions().size()); + ASSERT_EQ(4u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::DUPLICATE, kDuplicateBase, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 1)); @@ -177,7 +177,7 @@ TEST(FileDescriptorShuffleTest, CycleAndClose2) { map.push_back(InjectionArc(1, 0, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(4u, tracer.actions().size()); + ASSERT_EQ(4u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::DUPLICATE, kDuplicateBase, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 1)); @@ -192,7 +192,7 @@ TEST(FileDescriptorShuffleTest, CycleAndClose3) { map.push_back(InjectionArc(1, 0, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(4u, tracer.actions().size()); + ASSERT_EQ(4u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::DUPLICATE, kDuplicateBase, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 1)); @@ -207,7 +207,7 @@ TEST(FileDescriptorShuffleTest, Fanout) { map.push_back(InjectionArc(0, 2, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(2u, tracer.actions().size()); + ASSERT_EQ(2u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 2)); } @@ -219,7 +219,7 @@ TEST(FileDescriptorShuffleTest, FanoutAndClose1) { map.push_back(InjectionArc(0, 2, false)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(3u, tracer.actions().size()); + ASSERT_EQ(3u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 2)); EXPECT_TRUE(tracer.actions()[2] == Action(Action::CLOSE, 0)); @@ -232,7 +232,7 @@ TEST(FileDescriptorShuffleTest, FanoutAndClose2) { map.push_back(InjectionArc(0, 2, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(3u, tracer.actions().size()); + ASSERT_EQ(3u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 2)); EXPECT_TRUE(tracer.actions()[2] == Action(Action::CLOSE, 0)); @@ -245,7 +245,7 @@ TEST(FileDescriptorShuffleTest, FanoutAndClose3) { map.push_back(InjectionArc(0, 2, true)); EXPECT_TRUE(PerformInjectiveMultimap(map, &tracer)); - EXPECT_EQ(3u, tracer.actions().size()); + ASSERT_EQ(3u, tracer.actions().size()); EXPECT_TRUE(tracer.actions()[0] == Action(Action::MOVE, 0, 1)); EXPECT_TRUE(tracer.actions()[1] == Action(Action::MOVE, 0, 2)); EXPECT_TRUE(tracer.actions()[2] == Action(Action::CLOSE, 0)); |