diff options
| author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-29 13:11:36 +0000 |
|---|---|---|
| committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-29 13:11:36 +0000 |
| commit | 2423881b28e6944b3f61fe70af6222ef0a75d59e (patch) | |
| tree | 312b39ed379bd480db83b143fba419205698aed9 /base/file_path.cc | |
| parent | b7b24f6a1512fdfb3b1f292242e62490b5c6b9fd (diff) | |
| download | chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.zip chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.gz chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.bz2 | |
Move a few functions commonly called with char* to StringPiece.
In some cases this will avoid the implicit char* -> std::string conversion,
object creation, and string copying. One of the biggest benefit is on Windows,
where we can save some conversions in FilePath::AppendASCII.
Review URL: http://codereview.chromium.org/113996
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17182 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_path.cc')
| -rw-r--r-- | base/file_path.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/file_path.cc b/base/file_path.cc index b1bf687..a00659e 100644 --- a/base/file_path.cc +++ b/base/file_path.cc @@ -252,12 +252,12 @@ FilePath FilePath::Append(const FilePath& component) const { return Append(component.value()); } -FilePath FilePath::AppendASCII(const std::string& component) const { +FilePath FilePath::AppendASCII(const StringPiece& component) const { DCHECK(IsStringASCII(component)); #if defined(OS_WIN) return Append(ASCIIToWide(component)); #elif defined(OS_POSIX) - return Append(component); + return Append(component.as_string()); #endif } |