diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-03 01:17:26 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-03 01:17:26 +0000 |
commit | 44ec9b3b965335d661a144e11894da3cea999bf3 (patch) | |
tree | 549ce1740dda62e2014a75a7f3a6cff430dde45e /base/file_path.h | |
parent | 993e6ea820a8b71c8f7767822de3b66bd2bb3c6f (diff) | |
download | chromium_src-44ec9b3b965335d661a144e11894da3cea999bf3.zip chromium_src-44ec9b3b965335d661a144e11894da3cea999bf3.tar.gz chromium_src-44ec9b3b965335d661a144e11894da3cea999bf3.tar.bz2 |
Support reordering of Browser Actions within the container. Currently does not support dragging to/from the chevron menu.
Also fixed two bugs in the same code:
- the container would be 0 width if a value for it hasn't been saved (part of bug 32101).
- the default icon was not used when a tab specific icon was not found (bug 34317).
BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317
TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu.
Review URL: http://codereview.chromium.org/549224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37922 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_path.h')
-rw-r--r-- | base/file_path.h | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/base/file_path.h b/base/file_path.h index 0d0bdad..1e4952a 100644 --- a/base/file_path.h +++ b/base/file_path.h @@ -1,4 +1,4 @@ -// Copyright (c) 2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -116,6 +116,8 @@ #define FILE_PATH_USES_WIN_SEPARATORS #endif // OS_WIN +class Pickle; + // An abstraction to isolate users from the differences between native // pathnames on different platforms. class FilePath { @@ -282,6 +284,15 @@ class FilePath { // TODO(port): remove these functions. static FilePath FromWStringHack(const std::wstring& wstring); + // Static helper method to write a StringType to a pickle. + static void WriteStringTypeToPickle(Pickle* pickle, + const FilePath::StringType& path); + static bool ReadStringTypeFromPickle(Pickle* pickle, void** iter, + FilePath::StringType* path); + + void WriteToPickle(Pickle* pickle); + bool ReadFromPickle(Pickle* pickle, void** iter); + // Compare two strings in the same way the file system does. // Note that these always ignore case, even on file systems that are case- // sensitive. If case-sensitive comparison is ever needed, add corresponding |