diff options
| author | cevans@chromium.org <cevans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 21:44:31 +0000 |
|---|---|---|
| committer | cevans@chromium.org <cevans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 21:44:31 +0000 |
| commit | 067086103743fa898f4dedae1c7c07a9688c27be (patch) | |
| tree | d820f706c644698ed3fbe17d3e849dda6a158b0c /base/file_path_unittest.cc | |
| parent | 449f269f07a53ee461aa11e19533fb4c8a32d889 (diff) | |
| download | chromium_src-067086103743fa898f4dedae1c7c07a9688c27be.zip chromium_src-067086103743fa898f4dedae1c7c07a9688c27be.tar.gz chromium_src-067086103743fa898f4dedae1c7c07a9688c27be.tar.bz2 | |
Add "bool FilePath::ReferencesParent()" which adds a clean & simple way for
checking for ".." in a FilePath. Needed to make an upcoming security fix
clean.
BUG=NONE
TEST=FilePathTest.ReferencesParent
Review URL: http://codereview.chromium.org/172012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23528 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_path_unittest.cc')
| -rw-r--r-- | base/file_path_unittest.cc | 33 |
1 files changed, 32 insertions, 1 deletions
diff --git a/base/file_path_unittest.cc b/base/file_path_unittest.cc index ca30baa..e14bbca 100644 --- a/base/file_path_unittest.cc +++ b/base/file_path_unittest.cc @@ -535,7 +535,6 @@ TEST_F(FilePathTest, EqualityTest) { b.value(); } - for (size_t i = 0; i < arraysize(cases); ++i) { FilePath a(cases[i].inputs[0]); FilePath b(cases[i].inputs[1]); @@ -734,3 +733,35 @@ TEST_F(FilePathTest, MatchesExtension) { "i: " << i << ", path: " << path.value() << ", ext: " << ext; } } + +TEST_F(FilePathTest, ReferencesParent) { + const struct UnaryBooleanTestData cases[] = { + { FPL("."), false }, + { FPL(".."), true }, + { FPL("a.."), false }, + { FPL("..a"), false }, + { FPL("../"), true }, + { FPL("/.."), true }, + { FPL("/../"), true }, + { FPL("/a../"), false }, + { FPL("/..a/"), false }, + { FPL("//.."), true }, + { FPL("..//"), true }, + { FPL("//..//"), true }, + { FPL("a//..//c"), true }, + { FPL("../b/c"), true }, + { FPL("/../b/c"), true }, + { FPL("a/b/.."), true }, + { FPL("a/b/../"), true }, + { FPL("a/../c"), true }, + { FPL("a/b/c"), false }, + }; + + for (size_t i = 0; i < arraysize(cases); ++i) { + FilePath input(cases[i].input); + bool observed = input.ReferencesParent(); + EXPECT_EQ(cases[i].expected, observed) << + "i: " << i << ", input: " << input.value(); + } +} + |