diff options
| author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 14:41:51 +0000 |
|---|---|---|
| committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 14:41:51 +0000 |
| commit | ce16adb506bee0650584c64575423e2d120c75bd (patch) | |
| tree | bc6db25350ce984e233740cb0bf85f1a7bc39aeb /base/file_util.h | |
| parent | b182a98a89152bce37b35be5727b7d1e988c4ccd (diff) | |
| download | chromium_src-ce16adb506bee0650584c64575423e2d120c75bd.zip chromium_src-ce16adb506bee0650584c64575423e2d120c75bd.tar.gz chromium_src-ce16adb506bee0650584c64575423e2d120c75bd.tar.bz2 | |
Make sure it's possible to download to a network share.
The function to move the file was failing to set the
security descriptor. Now we use SHFileOperation, which
has a flag to do everything we want.
Eventually we might want to display ui on errors and
use the ui features of SHFileOperation, but for the
1.0 build we want to stick to a smaller and less risky
change.
BUG: 984
Review URL: http://codereview.chromium.org/8128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3996 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_util.h')
| -rw-r--r-- | base/file_util.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/file_util.h b/base/file_util.h index 150b629..8594d28 100644 --- a/base/file_util.h +++ b/base/file_util.h @@ -346,8 +346,8 @@ class FileEnumerator { DISALLOW_EVIL_CONSTRUCTORS(FileEnumerator); }; -// Renames a file using the MoveFileEx API and ensures that the target file gets -// the correct security descriptor in the new path. +// Renames a file using the SHFileOperation API to ensure that the target file +// gets the correct default security descriptor in the new path. bool RenameFileAndResetSecurityDescriptor( const std::wstring& source_file_path, const std::wstring& target_file_path); |