diff options
author | huanr@chromium.org <huanr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 19:34:59 +0000 |
---|---|---|
committer | huanr@chromium.org <huanr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 19:34:59 +0000 |
commit | 7075b06c4ddb77982b62ffcecb46a6c52d7860f4 (patch) | |
tree | 2f0e1f34ef05253c573b4cfbe3a7ff48fe7dfe8f /base/file_util_posix.cc | |
parent | 37048f235367c282f1dba8c26364050dfc083d90 (diff) | |
download | chromium_src-7075b06c4ddb77982b62ffcecb46a6c52d7860f4.zip chromium_src-7075b06c4ddb77982b62ffcecb46a6c52d7860f4.tar.gz chromium_src-7075b06c4ddb77982b62ffcecb46a6c52d7860f4.tar.bz2 |
Revert 31875 to see whether it fixes reliability bot.
BUG=25677
TEST=None
Review URL: http://codereview.chromium.org/397014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32074 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_util_posix.cc')
-rw-r--r-- | base/file_util_posix.cc | 42 |
1 files changed, 33 insertions, 9 deletions
diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc index a269d3f..1a05d79 100644 --- a/base/file_util_posix.cc +++ b/base/file_util_posix.cc @@ -667,23 +667,47 @@ bool FileEnumerator::ReadDirectory(std::vector<DirectoryEntryInfo>* entries, // MemoryMappedFile MemoryMappedFile::MemoryMappedFile() - : file_(base::kInvalidPlatformFileValue), - data_(NULL), + : data_(NULL), length_(0) { } +bool MemoryMappedFile::Initialize(const base::FileDescriptor& fd) { + if (IsValid()) + return false; + + file_ = fd; + + if (!MapFileToMemoryInternal()) { + CloseHandles(); + return false; + } + + return true; +} + +bool MemoryMappedFile::MapFileToMemory(const FilePath& file_name) { + file_ = base::FileDescriptor(open(file_name.value().c_str(), O_RDONLY), true); + + if (file_.fd == -1) { + LOG(ERROR) << "Couldn't open " << file_name.value(); + return false; + } + + return MapFileToMemoryInternal(); +} + bool MemoryMappedFile::MapFileToMemoryInternal() { struct stat file_stat; - if (fstat(file_, &file_stat) == base::kInvalidPlatformFileValue) { - LOG(ERROR) << "Couldn't fstat " << file_ << ", errno " << errno; + if (fstat(file_.fd, &file_stat) == -1) { + LOG(ERROR) << "Couldn't fstat " << file_.fd << ", errno " << errno; return false; } length_ = file_stat.st_size; data_ = static_cast<uint8*>( - mmap(NULL, length_, PROT_READ, MAP_SHARED, file_, 0)); + mmap(NULL, length_, PROT_READ, MAP_SHARED, file_.fd, 0)); if (data_ == MAP_FAILED) - LOG(ERROR) << "Couldn't mmap " << file_ << ", errno " << errno; + LOG(ERROR) << "Couldn't mmap " << file_.fd << ", errno " << errno; return data_ != MAP_FAILED; } @@ -691,12 +715,12 @@ bool MemoryMappedFile::MapFileToMemoryInternal() { void MemoryMappedFile::CloseHandles() { if (data_ != NULL) munmap(data_, length_); - if (file_ != base::kInvalidPlatformFileValue) - close(file_); + if (file_.auto_close && file_.fd != -1) + close(file_.fd); data_ = NULL; length_ = 0; - file_ = base::kInvalidPlatformFileValue; + file_ = base::FileDescriptor(); } } // namespace file_util |