diff options
| author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
|---|---|---|
| committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
| commit | 57b765671983005059e8be4523872796b9505428 (patch) | |
| tree | c84b82b586cae2b39ef784f1ee1d58c1431bb140 /base/file_util_posix.cc | |
| parent | fd8d08436730ef67591de7665da88e995159b773 (diff) | |
| download | chromium_src-57b765671983005059e8be4523872796b9505428.zip chromium_src-57b765671983005059e8be4523872796b9505428.tar.gz chromium_src-57b765671983005059e8be4523872796b9505428.tar.bz2 | |
Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().
TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none
Review URL: http://codereview.chromium.org/261055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_util_posix.cc')
| -rw-r--r-- | base/file_util_posix.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc index 4d9e797..3ba351e 100644 --- a/base/file_util_posix.cc +++ b/base/file_util_posix.cc @@ -99,7 +99,7 @@ int CountFilesCreatedAfter(const FilePath& path, stat_wrapper_t st; int test = CallStat(path.Append(ent->d_name).value().c_str(), &st); if (test != 0) { - LOG(ERROR) << "stat64 failed: " << strerror(errno); + PLOG(ERROR) << "stat64 failed"; continue; } // Here, we use Time::TimeT(), which discards microseconds. This @@ -634,9 +634,8 @@ bool FileEnumerator::ReadDirectory(std::vector<DirectoryEntryInfo>* entries, // Print the stat() error message unless it was ENOENT and we're // following symlinks. if (!(ret == ENOENT && !show_links)) { - LOG(ERROR) << "Couldn't stat " - << source.Append(dent->d_name).value() << ": " - << strerror(errno); + PLOG(ERROR) << "Couldn't stat " + << source.Append(dent->d_name).value(); } memset(&info.stat, 0, sizeof(info.stat)); } |