ImportantFileWriter

Introducing a class for writing important files, preventing their corruption during writing.

Switched PrefService to use it. Other classes will be switched in future changesets.

TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences.

http://crbug.com/10618

Review URL: http://codereview.chromium.org/83001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 16 deletions

diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc
index f218460..1835d3a 100644
--- a/base/file_util_posix.cc
+++ b/base/file_util_posix.cc
@@ -369,30 +369,20 @@ bool CreateTemporaryFileName(FilePath* path) {
   return true;
 }
 
-FILE* CreateAndOpenTemporaryFile(FilePath* path) {
-  FilePath directory;
-  if (!GetTempDir(&directory))
-    return false;
-
-  int fd = CreateAndOpenFdForTemporaryFile(directory, path);
-  if (fd < 0)
-    return NULL;
-
-  FILE *fp = fdopen(fd, "a+");
-  return fp;
-}
-
 FILE* CreateAndOpenTemporaryShmemFile(FilePath* path) {
   FilePath directory;
   if (!GetShmemTempDir(&directory))
     return false;
 
-  int fd = CreateAndOpenFdForTemporaryFile(directory, path);
+  return CreateAndOpenTemporaryFileInDir(directory, path);
+}
+
+FILE* CreateAndOpenTemporaryFileInDir(const FilePath& dir, FilePath* path) {
+  int fd = CreateAndOpenFdForTemporaryFile(dir, path);
   if (fd < 0)
     return NULL;
 
-  FILE *fp = fdopen(fd, "a+");
-  return fp;
+  return fdopen(fd, "a+");
 }
 
 bool CreateTemporaryFileNameInDir(const std::wstring& dir,