diff options
| author | sanga@chromium.org <sanga@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-17 16:45:48 +0000 |
|---|---|---|
| committer | sanga@chromium.org <sanga@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-17 16:45:48 +0000 |
| commit | a88016d19c4e05687cc9b1cf10fda7ef849c3db9 (patch) | |
| tree | 2387d3694246441c7276e7cd41fd66745b1a16b7 /base/file_util_proxy.cc | |
| parent | cc25dba3d78ec1657aaa5ad9f286ac771b5c9bc4 (diff) | |
| download | chromium_src-a88016d19c4e05687cc9b1cf10fda7ef849c3db9.zip chromium_src-a88016d19c4e05687cc9b1cf10fda7ef849c3db9.tar.gz chromium_src-a88016d19c4e05687cc9b1cf10fda7ef849c3db9.tar.bz2 | |
Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write
Also made some minor changes to fix lint warnings.
There are no tests for base::FileUtilProxy.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2076
TEST= test_shell_tests
Review URL: http://codereview.chromium.org/7651002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97147 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_util_proxy.cc')
| -rw-r--r-- | base/file_util_proxy.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/base/file_util_proxy.cc b/base/file_util_proxy.cc index 2d5125f..0e4badf 100644 --- a/base/file_util_proxy.cc +++ b/base/file_util_proxy.cc @@ -868,6 +868,8 @@ bool FileUtilProxy::Write( const char* buffer, int bytes_to_write, WriteCallback* callback) { + if (bytes_to_write <= 0) + return false; return Start(FROM_HERE, message_loop_proxy, new RelayWrite(file, offset, buffer, bytes_to_write, callback)); } |