diff options
| author | avi@google.com <avi@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 16:57:36 +0000 |
|---|---|---|
| committer | avi@google.com <avi@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 16:57:36 +0000 |
| commit | 095622382c96432f4c90e69eb7591ebe9e5e3d46 (patch) | |
| tree | 5ee1d78b950af33c3b544ae911d0d4b40786a458 /base/file_version_info.h | |
| parent | 40f52f0c52a82bc988bc95dc296ddfa89f09154a (diff) | |
| download | chromium_src-095622382c96432f4c90e69eb7591ebe9e5e3d46.zip chromium_src-095622382c96432f4c90e69eb7591ebe9e5e3d46.tar.gz chromium_src-095622382c96432f4c90e69eb7591ebe9e5e3d46.tar.bz2 | |
Add FilePath support to FileVersionInfo, fix Mac memory issues.
Review URL: http://codereview.chromium.org/15082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/file_version_info.h')
| -rw-r--r-- | base/file_version_info.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/base/file_version_info.h b/base/file_version_info.h index d2d6630..653aaf3 100644 --- a/base/file_version_info.h +++ b/base/file_version_info.h @@ -8,6 +8,7 @@ #include <string> #include "base/basictypes.h" +#include "base/file_path.h" #include "base/scoped_ptr.h" #ifdef OS_MACOSX @@ -27,6 +28,9 @@ class FileVersionInfo { // Creates a FileVersionInfo for the specified path. Returns NULL if something // goes wrong (typically the file does not exit or cannot be opened). The // returned object should be deleted when you are done with it. + static FileVersionInfo* CreateFileVersionInfo(const FilePath& file_path); + // This version, taking a wstring, is deprecated and only kept around + // until we can fix all callers. static FileVersionInfo* CreateFileVersionInfo(const std::wstring& file_path); // Creates a FileVersionInfo for the current module. Returns NULL in case @@ -77,7 +81,6 @@ class FileVersionInfo { VS_FIXEDFILEINFO* fixed_file_info_; #elif defined(OS_MACOSX) explicit FileVersionInfo(NSBundle *bundle); - explicit FileVersionInfo(const std::wstring& file_path); NSBundle *bundle_; #endif |