summaryrefslogtreecommitdiffstats
path: root/base/gfx/base_gfx.scons
diff options
context:
space:
mode:
authorsgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-18 23:26:29 +0000
committersgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-18 23:26:29 +0000
commitb96fc5dc177d311db220dc4039e74a9c0d871558 (patch)
tree9bbc6ea3af7c0da75d4b6025d4b475dd62eec0b2 /base/gfx/base_gfx.scons
parentdb8635032b1f83436a072be14e425076a7bd8164 (diff)
downloadchromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.zip
chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.gz
chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.bz2
Convert from using env['PLATFORM'] directly to using the more flexible
and better-thought-out Hammer env.Bits() idioms: * env['PLATFORM'] == 'win32' => env.Bit('windows') * env['PLATFORM'] == 'posix' => env.Bit('linux') * env['PLATFORM'] == 'darwin' => env.Bit('mac') New idioms: * env.Bit('posix') => really does mean "any POSIX platform" * env.AnyBits('mac', 'linux') => specifically mac or linux, excluding other POSIX platforms Where we were using compound conditionals (e.g., "env['PLATFORM'] in ('posix', 'darwin')") I tried to take my best shot at translating the intent (i.e., "env.Bits('posix')" for something POSIX, "not env.Bits('mac')" for something not yet ported to Mac, etc.) Review URL: http://codereview.chromium.org/15051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/gfx/base_gfx.scons')
-rw-r--r--base/gfx/base_gfx.scons8
1 files changed, 4 insertions, 4 deletions
diff --git a/base/gfx/base_gfx.scons b/base/gfx/base_gfx.scons
index a69206b..2dc9dc9 100644
--- a/base/gfx/base_gfx.scons
+++ b/base/gfx/base_gfx.scons
@@ -17,7 +17,7 @@ env.ApplySConscript([
'$ZLIB_DIR/using_zlib.scons',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CCFLAGS = [
'/WX',
@@ -34,7 +34,7 @@ input_files = [
'size.cc',
]
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
# Remove files that still need to be ported from the input_files list.
# TODO(port): delete files from this list as they get ported.
to_be_ported_files = [
@@ -44,10 +44,10 @@ if env['PLATFORM'] in ('posix', 'darwin'):
for remove in to_be_ported_files:
input_files.remove(remove)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
input_files.extend([
])
-elif env['PLATFORM'] == 'posix':
+elif env.Bit('linux'):
input_files.extend([
])