diff options
| author | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-26 22:10:13 +0000 |
|---|---|---|
| committer | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-26 22:10:13 +0000 |
| commit | be36adf48521bae3965b79a852501c696413f133 (patch) | |
| tree | 0458f2785af75473570b2604431e3f77b7cd9d88 /base/gfx/rect_unittest.cc | |
| parent | b50ed4828c28ac9b4baad3801a1f9938e913d289 (diff) | |
| download | chromium_src-be36adf48521bae3965b79a852501c696413f133.zip chromium_src-be36adf48521bae3965b79a852501c696413f133.tar.gz chromium_src-be36adf48521bae3965b79a852501c696413f133.tar.bz2 | |
Change Size::IsEmpty() to be consistent with Rect::IsEmpty()
Change Size to not accept negative dimensions to be consistent with Rect.
BUG=10992
TEST=base_unittests.exe --gtest_filter=RectTest.IsEmpty
Review URL: http://codereview.chromium.org/93131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14567 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/gfx/rect_unittest.cc')
| -rw-r--r-- | base/gfx/rect_unittest.cc | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/base/gfx/rect_unittest.cc b/base/gfx/rect_unittest.cc index 31ca6c1..50c789d 100644 --- a/base/gfx/rect_unittest.cc +++ b/base/gfx/rect_unittest.cc @@ -267,3 +267,14 @@ TEST(RectTest, Subtract) { gfx::Rect(5, 5, 20, 30)).Equals( gfx::Rect(25, 10, 5, 20))); } + +TEST(RectTest, IsEmpty) { + EXPECT_TRUE(gfx::Rect(0, 0, 0, 0).IsEmpty()); + EXPECT_TRUE(gfx::Rect(0, 0, 0, 0).size().IsEmpty()); + EXPECT_TRUE(gfx::Rect(0, 0, 10, 0).IsEmpty()); + EXPECT_TRUE(gfx::Rect(0, 0, 10, 0).size().IsEmpty()); + EXPECT_TRUE(gfx::Rect(0, 0, 0, 10).IsEmpty()); + EXPECT_TRUE(gfx::Rect(0, 0, 0, 10).size().IsEmpty()); + EXPECT_FALSE(gfx::Rect(0, 0, 10, 10).IsEmpty()); + EXPECT_FALSE(gfx::Rect(0, 0, 10, 10).size().IsEmpty()); +} |