summaryrefslogtreecommitdiffstats
path: root/base/gfx
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-26 00:33:37 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-26 00:33:37 +0000
commit3b33faae96e4cf42ec6b0da5163668b1e482d821 (patch)
tree05bc5e540fdd3150cdc256d46b0602df0670c441 /base/gfx
parent5f1b0d6b9fb0b529202c63e99a67032cf1a306c9 (diff)
downloadchromium_src-3b33faae96e4cf42ec6b0da5163668b1e482d821.zip
chromium_src-3b33faae96e4cf42ec6b0da5163668b1e482d821.tar.gz
chromium_src-3b33faae96e4cf42ec6b0da5163668b1e482d821.tar.bz2
linux plugins: eliminate GtkWidget* from plugin process
GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19320 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/gfx')
-rw-r--r--base/gfx/native_widget_types.h13
1 files changed, 13 insertions, 0 deletions
diff --git a/base/gfx/native_widget_types.h b/base/gfx/native_widget_types.h
index 9444a61..bd8815c 100644
--- a/base/gfx/native_widget_types.h
+++ b/base/gfx/native_widget_types.h
@@ -114,6 +114,19 @@ static inline NativeViewId IdFromNativeView(NativeView view) {
NativeViewId IdFromNativeView(NativeView view);
#endif // defined(OS_LINUX)
+
+// PluginWindowHandle is an abstraction wrapping "the types of windows
+// used by NPAPI plugins". On Windows it's an HWND, on X it's an X
+// window id.
+#if defined(OS_WIN)
+ typedef HWND PluginWindowHandle;
+#elif defined(OS_LINUX)
+ typedef unsigned long PluginWindowHandle;
+#else
+ // On OS X we don't have windowed plugins.
+ typedef void* PluginWindowHandle;
+#endif
+
} // namespace gfx
#endif // BASE_GFX_NATIVE_WIDGET_TYPES_H_