diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-07 17:40:46 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-07 17:40:46 +0000 |
| commit | 700d3d58213d15dea1beb2f7f7122e77e7ea2a47 (patch) | |
| tree | 5d6a3c72fa58cccd7a7f7ddba5c77ed0edbe5135 /base/gfx | |
| parent | d1ae85447a12e97b0758b0d113a12e2d6c6d09b4 (diff) | |
| download | chromium_src-700d3d58213d15dea1beb2f7f7122e77e7ea2a47.zip chromium_src-700d3d58213d15dea1beb2f7f7122e77e7ea2a47.tar.gz chromium_src-700d3d58213d15dea1beb2f7f7122e77e7ea2a47.tar.bz2 | |
linux: OOP windowed plugins
There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably refactor it, but I'm not sure where the common part should live.
Patch from Antoine Labour <piman@google.com>, with some touchups by me.
Review URL: http://codereview.chromium.org/146078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20041 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/gfx')
| -rw-r--r-- | base/gfx/native_widget_types.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/gfx/native_widget_types.h b/base/gfx/native_widget_types.h index e9a9230..bec3313 100644 --- a/base/gfx/native_widget_types.h +++ b/base/gfx/native_widget_types.h @@ -124,9 +124,9 @@ NativeViewId IdFromNativeView(NativeView view); typedef unsigned long PluginWindowHandle; #else // On OS X we don't have windowed plugins. - // Use a gfx::NativeView so the previously-compiling code still works. - // TODO(evanm): remove this and use void* instead. - typedef gfx::NativeView PluginWindowHandle; + // We use a NULL/0 PluginWindowHandle in shared code to indicate there + // is no window present, so mirror that behavior here. + typedef bool PluginWindowHandle; #endif } // namespace gfx |