diff options
author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-10 22:29:29 +0000 |
---|---|---|
committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-10 22:29:29 +0000 |
commit | e6f02aba72e297560ece0e79d165abf4c49149ff (patch) | |
tree | 95fb68ad511b0ac62e2532c47f46362afff39f88 /base/histogram.cc | |
parent | caae50cacfe0304045b9a961af797e3cf38bde23 (diff) | |
download | chromium_src-e6f02aba72e297560ece0e79d165abf4c49149ff.zip chromium_src-e6f02aba72e297560ece0e79d165abf4c49149ff.tar.gz chromium_src-e6f02aba72e297560ece0e79d165abf4c49149ff.tar.bz2 |
Remove histogram connection to base classes in stats_counter
Now that histograms move data from renderer to browser, there
is less reason to connect to stats counters.
Stats counters were using shared memory, and now they may
plausibly use the histogram's IPC mechanism instead to
move data to the browser. The first step is remove the
inheritance, and teh next (plausible/future) step
would be to implement counters as histograms with only
one bucket.
r=mbelshe
Review URL: http://codereview.chromium.org/66029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/histogram.cc')
-rw-r--r-- | base/histogram.cc | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/base/histogram.cc b/base/histogram.cc index d1568429..687a549 100644 --- a/base/histogram.cc +++ b/base/histogram.cc @@ -25,8 +25,7 @@ const int Histogram::kHexRangePrintingFlag = 0x8000; Histogram::Histogram(const char* name, Sample minimum, Sample maximum, size_t bucket_count) - : StatsRate(name), - histogram_name_(name), + : histogram_name_(name), declared_min_(minimum), declared_max_(maximum), bucket_count_(bucket_count), @@ -39,8 +38,7 @@ Histogram::Histogram(const char* name, Sample minimum, Histogram::Histogram(const char* name, TimeDelta minimum, TimeDelta maximum, size_t bucket_count) - : StatsRate(name), - histogram_name_(name), + : histogram_name_(name), declared_min_(static_cast<int> (minimum.InMilliseconds())), declared_max_(static_cast<int> (maximum.InMilliseconds())), bucket_count_(bucket_count), @@ -58,14 +56,11 @@ Histogram::~Histogram() { DCHECK(ValidateBucketRanges()); } -// Hooks to override stats counter methods. This ensures that we gather all -// input the stats counter sees. void Histogram::Add(int value) { if (!registered_) registered_ = StatisticsRecorder::Register(this); if (value >= kSampleType_MAX) value = kSampleType_MAX - 1; - StatsRate::Add(value); if (value < 0) value = 0; size_t index = BucketIndex(value); @@ -631,7 +626,6 @@ ThreadSafeHistogram::ThreadSafeHistogram(const char* name, Sample minimum, void ThreadSafeHistogram::Remove(int value) { if (value >= kSampleType_MAX) value = kSampleType_MAX - 1; - StatsRate::Add(-value); size_t index = BucketIndex(value); Accumulate(value, -1, index); } |