diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-25 02:12:09 +0000 |
| commit | da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0 (patch) | |
| tree | 5e8bfb0503ab08a672054fa34e04ef7cce3d0d2f /base/i18n | |
| parent | 6c293a7baba7aa1d998e2680492246f239a7015d (diff) | |
| download | chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.zip chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.gz chromium_src-da7d86e75fe4a37ef12f3ae4bd28b043932d2aa0.tar.bz2 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/i18n')
| -rw-r--r-- | base/i18n/icu_util.cc | 8 | ||||
| -rw-r--r-- | base/i18n/time_formatting.cc | 6 |
2 files changed, 7 insertions, 7 deletions
diff --git a/base/i18n/icu_util.cc b/base/i18n/icu_util.cc index 4f17f177..e5bbe17 100644 --- a/base/i18n/icu_util.cc +++ b/base/i18n/icu_util.cc @@ -68,13 +68,13 @@ bool Initialize() { HMODULE module = LoadLibrary(data_path.value().c_str()); if (!module) { - LOG(ERROR) << "Failed to load " << ICU_UTIL_DATA_SHARED_MODULE_NAME; + DLOG(ERROR) << "Failed to load " << ICU_UTIL_DATA_SHARED_MODULE_NAME; return false; } FARPROC addr = GetProcAddress(module, ICU_UTIL_DATA_SYMBOL); if (!addr) { - LOG(ERROR) << ICU_UTIL_DATA_SYMBOL << ": not found in " + DLOG(ERROR) << ICU_UTIL_DATA_SYMBOL << ": not found in " << ICU_UTIL_DATA_SHARED_MODULE_NAME; return false; } @@ -113,11 +113,11 @@ bool Initialize() { FilePath data_path = base::mac::PathForMainAppBundleResource(CFSTR(ICU_UTIL_DATA_FILE_NAME)); if (data_path.empty()) { - LOG(ERROR) << ICU_UTIL_DATA_FILE_NAME << " not found in bundle"; + DLOG(ERROR) << ICU_UTIL_DATA_FILE_NAME << " not found in bundle"; return false; } if (!mapped_file.Initialize(data_path)) { - LOG(ERROR) << "Couldn't mmap " << data_path.value(); + DLOG(ERROR) << "Couldn't mmap " << data_path.value(); return false; } } diff --git a/base/i18n/time_formatting.cc b/base/i18n/time_formatting.cc index 419e8db..9906dba 100644 --- a/base/i18n/time_formatting.cc +++ b/base/i18n/time_formatting.cc @@ -75,15 +75,15 @@ string16 TimeFormatTimeOfDayWithHourClockType(const Time& time, UErrorCode status = U_ZERO_ERROR; scoped_ptr<icu::DateTimePatternGenerator> generator( icu::DateTimePatternGenerator::createInstance(status)); - CHECK(U_SUCCESS(status)); + DCHECK(U_SUCCESS(status)); const char* base_pattern = (type == k12HourClock ? "ahm" : "Hm"); icu::UnicodeString generated_pattern = generator->getBestPattern(icu::UnicodeString(base_pattern), status); - CHECK(U_SUCCESS(status)); + DCHECK(U_SUCCESS(status)); // Then, format the time using the generated pattern. icu::SimpleDateFormat formatter(generated_pattern, status); - CHECK(U_SUCCESS(status)); + DCHECK(U_SUCCESS(status)); if (ampm == kKeepAmPm) { return TimeFormat(&formatter, time); } else { |