diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-31 01:38:18 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-31 01:38:18 +0000 |
| commit | c19003d908b82366f7f219a07d961580efab40c8 (patch) | |
| tree | 7360d15cf02abe210c709d86a13601c9a29c3f27 /base/json | |
| parent | 1eec7faa1e2f45236e2682bffec8e6d71d3f8a1e (diff) | |
| download | chromium_src-c19003d908b82366f7f219a07d961580efab40c8.zip chromium_src-c19003d908b82366f7f219a07d961580efab40c8.tar.gz chromium_src-c19003d908b82366f7f219a07d961580efab40c8.tar.bz2 | |
base: Add missing "virtual" keyword and OVERRIDE to some methods.
Found with:
$ ./build/gyp_chromium -Dclang=1 -Dclang_use_chrome_plugins=1
$ ninja -C out/Debug base -k4 -j4 2>&1 | tee errors
And a tweak in plugin_flags.sh
BUG=115047
R=willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149109 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/json')
| -rw-r--r-- | base/json/json_parser.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc index 738da47..0cb59ee 100644 --- a/base/json/json_parser.cc +++ b/base/json/json_parser.cc @@ -140,12 +140,12 @@ class JSONStringValue : public base::Value { string_piece_(piece) { } - // Value: - bool GetAsString(std::string* out_value) const OVERRIDE { + // Overridden from base::Value: + virtual bool GetAsString(std::string* out_value) const OVERRIDE { string_piece_.CopyToString(out_value); return true; } - bool GetAsString(string16* out_value) const OVERRIDE { + virtual bool GetAsString(string16* out_value) const OVERRIDE { *out_value = UTF8ToUTF16(string_piece_); return true; } |