diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-30 03:44:25 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-30 03:44:25 +0000 |
| commit | f0ab5bae61e2691b4434e67d124247b9a7c4d1e8 (patch) | |
| tree | 5aadb1578fa27fcd113a4d193df8f2010497d760 /base/location.h | |
| parent | 0bc27162426c0597db38942f09ab00382c67dfb6 (diff) | |
| download | chromium_src-f0ab5bae61e2691b4434e67d124247b9a7c4d1e8.zip chromium_src-f0ab5bae61e2691b4434e67d124247b9a7c4d1e8.tar.gz chromium_src-f0ab5bae61e2691b4434e67d124247b9a7c4d1e8.tar.bz2 | |
Fully enable about:tracking by default
This is a re-land of:
http://codereview.chromium.org/8391019/
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793
Original landing had trouble with message_loop_x.h, due to header
include ordering. I pulled out the structure that was really needed by
tracked_objects.h into a new file tracked_info.*. This allows tracked_objects
to inlude this tracked_info, but not have to include the message_loop.h
totality. I also removed a DCHECK that that was triggering on a test,
and added yet one more file (browser_main.cc) where I removed a #ifdef
for TRACKING_ALL_OBJECTS. The changes were minor, and I'm hoping to get
clear perf runs with tihs landing, so I'm going to TBR it and reland
early in the morning.
Comments from original landing:
Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0
All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops)
by a single const bool setting atop tracked_objects.cc (in
case folks want to revert the perf-impact of this change).
Transition to faster Now() service on Windows for the
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).
I've also put in yet more cleanup and refactoring.
tbr=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8414036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107895 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/location.h')
| -rw-r--r-- | base/location.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/base/location.h b/base/location.h index 42b3a92..523bfaf 100644 --- a/base/location.h +++ b/base/location.h @@ -10,12 +10,6 @@ #include "base/base_export.h" #include "base/values.h" -#ifndef NDEBUG -#ifndef TRACK_ALL_TASK_OBJECTS -#define TRACK_ALL_TASK_OBJECTS -#endif // TRACK_ALL_TASK_OBJECTS -#endif // NDEBUG - namespace tracked_objects { // Location provides basic info where of an object was constructed, or was |