diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-27 15:38:07 +0000 |
| commit | f55bd486ab0ada0402fdcd34fb70a20d155fd968 (patch) | |
| tree | 1eb9cf7c078d40c20320126d34f4cc4694082b1f /base/lock_impl_win.cc | |
| parent | 4b0bd5f4c2d58c1620b49628be68f877928025fd (diff) | |
| download | chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.zip chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.gz chromium_src-f55bd486ab0ada0402fdcd34fb70a20d155fd968.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/lock_impl_win.cc')
| -rw-r--r-- | base/lock_impl_win.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/lock_impl_win.cc b/base/lock_impl_win.cc index 0f0e424..0d1ac93 100644 --- a/base/lock_impl_win.cc +++ b/base/lock_impl_win.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -29,7 +29,7 @@ bool LockImpl::Try() { #ifndef NDEBUG // ONLY access data after locking. owning_thread_id_ = PlatformThread::CurrentId(); - DCHECK_NE(owning_thread_id_, 0); + DCHECK_NE(owning_thread_id_, 0u); recursion_count_shadow_++; if (2 == recursion_count_shadow_ && !recursion_used_) { recursion_used_ = true; @@ -46,7 +46,7 @@ void LockImpl::Lock() { #ifndef NDEBUG // ONLY access data after locking. owning_thread_id_ = PlatformThread::CurrentId(); - DCHECK_NE(owning_thread_id_, 0); + DCHECK_NE(owning_thread_id_, 0u); recursion_count_shadow_++; if (2 == recursion_count_shadow_ && !recursion_used_) { recursion_used_ = true; |