diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 15:43:06 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 15:43:06 +0000 |
| commit | 469006ca33c230e7e815150a2ae0cf8dd46c91cd (patch) | |
| tree | ac2761080d28378786191136b1863c418a5ebcf6 /base/logging.cc | |
| parent | 075be5d0fe3c21a7405906172dafc76f2343b3da (diff) | |
| download | chromium_src-469006ca33c230e7e815150a2ae0cf8dd46c91cd.zip chromium_src-469006ca33c230e7e815150a2ae0cf8dd46c91cd.tar.gz chromium_src-469006ca33c230e7e815150a2ae0cf8dd46c91cd.tar.bz2 | |
Include log output in buildbot logs on Windows just as
we do on Linux and Mac. This can be very helpful when
trying to debug flaky tests.
R=erikkay
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3435027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60472 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.cc')
| -rw-r--r-- | base/logging.cc | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/base/logging.cc b/base/logging.cc index 9808860..780da86 100644 --- a/base/logging.cc +++ b/base/logging.cc @@ -569,22 +569,9 @@ LogMessage::~LogMessage() { logging_destination == LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG) { #if defined(OS_WIN) OutputDebugStringA(str_newline.c_str()); - if (severity_ >= kAlwaysPrintErrorLevel) { -#else - { #endif - // TODO(erikkay): this interferes with the layout tests since it grabs - // stderr and stdout and diffs them against known data. Our info and warn - // logs add noise to that. Ideally, the layout tests would set the log - // level to ignore anything below error. When that happens, we should - // take this fprintf out of the #else so that Windows users can benefit - // from the output when running tests from the command-line. In the - // meantime, we leave this in for Mac and Linux, but until this is fixed - // they won't be able to pass any layout tests that have info or warn - // logs. See http://b/1343647 - fprintf(stderr, "%s", str_newline.c_str()); - fflush(stderr); - } + fprintf(stderr, "%s", str_newline.c_str()); + fflush(stderr); } else if (severity_ >= kAlwaysPrintErrorLevel) { // When we're only outputting to a log file, above a certain log level, we // should still output to stderr so that we can better detect and diagnose |