diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 22:38:30 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 22:38:30 +0000 |
| commit | 8b78210f6a76367500196e78ab8d30cc475f4e81 (patch) | |
| tree | 42c55cd851b8f7c01e93f021d71a0b194b1e66e4 /base/logging.cc | |
| parent | 3b19bd82c20aebabfe05c449288047b57f202d27 (diff) | |
| download | chromium_src-8b78210f6a76367500196e78ab8d30cc475f4e81.zip chromium_src-8b78210f6a76367500196e78ab8d30cc475f4e81.tar.gz chromium_src-8b78210f6a76367500196e78ab8d30cc475f4e81.tar.bz2 | |
Revert 61127 - Made logging macros evaluate its stream arguments lazily.
Also added logging unittests.
BUG=57383
TEST=logging_unittest.cc
Review URL: http://codereview.chromium.org/3575008
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3606003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61129 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.cc')
| -rw-r--r-- | base/logging.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/base/logging.cc b/base/logging.cc index ce05d21..f0c6217 100644 --- a/base/logging.cc +++ b/base/logging.cc @@ -561,9 +561,8 @@ void LogMessage::Init(const char* file, int line) { } LogMessage::~LogMessage() { - // The macros in logging.h should already avoid creating LogMessages - // when this holds, but it's possible that users create LogMessages - // directly (e.g., using LOG_STREAM() directly). + // TODO(brettw) modify the macros so that nothing is executed when the log + // level is too high. if (severity_ < min_log_level) return; |