diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-04 06:04:46 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-04 06:04:46 +0000 |
| commit | 22d95569efd2064e51bf727cee6f44297a4e9013 (patch) | |
| tree | 12ae8e62608f576eb97f62210d0648551bfbd8a8 /base/logging.cc | |
| parent | 4fe56181ecf3dbe0adb2bfd448040d8b37cb2536 (diff) | |
| download | chromium_src-22d95569efd2064e51bf727cee6f44297a4e9013.zip chromium_src-22d95569efd2064e51bf727cee6f44297a4e9013.tar.gz chromium_src-22d95569efd2064e51bf727cee6f44297a4e9013.tar.bz2 | |
Implement basic stack traces on Android and reenable unit tests.
Since we install stripped binaries in APKs, print out object file names and relocatable addresses that can be used on the host machine to complete symbolizing and demangling the stack trace using unstripped binaries.
In addition the implementation of StackTrace::PrintBacktrace() was changed to log the stack trace instead of sending SIGSTKFLT.
BUG=248775, 248784
Review URL: https://chromiumcodereview.appspot.com/16770006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210132 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.cc')
| -rw-r--r-- | base/logging.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/base/logging.cc b/base/logging.cc index 3b78387..16cd2f8 100644 --- a/base/logging.cc +++ b/base/logging.cc @@ -556,9 +556,7 @@ LogMessage::LogMessage(const char* file, int line, LogSeverity severity, } LogMessage::~LogMessage() { - // TODO(port): enable stacktrace generation on LOG_FATAL once backtrace are - // working in Android. -#if !defined(NDEBUG) && !defined(OS_ANDROID) && !defined(OS_NACL) +#if !defined(NDEBUG) && !defined(OS_NACL) if (severity_ == LOG_FATAL) { // Include a stack trace on a fatal. base::debug::StackTrace trace; |