diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 01:01:04 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 01:01:04 +0000 |
| commit | 081bd4cdbbd88394b34bfc454b62f9b8a1e6d85e (patch) | |
| tree | b6740c0321aaab0c532b6b6d3cd1bf1ebb22d76c /base/logging.h | |
| parent | 7060bb292ea9e20cb0f45dadd1a2b06ef61bcc2f (diff) | |
| download | chromium_src-081bd4cdbbd88394b34bfc454b62f9b8a1e6d85e.zip chromium_src-081bd4cdbbd88394b34bfc454b62f9b8a1e6d85e.tar.gz chromium_src-081bd4cdbbd88394b34bfc454b62f9b8a1e6d85e.tar.bz2 | |
Change LOG(DFATAL) to avoid dialog in production build
Old semantics:
In DEBUG mode: no change: Fatal CHECK error and dialog.
In Release mode: Dialog for user, but allow user to continue.
New semantics:
In Release mode: LOG(ERROR), but don't bother the user.
r=brettw,willchan
Review URL: http://codereview.chromium.org/2872014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50679 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.h')
| -rw-r--r-- | base/logging.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/logging.h b/base/logging.h index 07a0d0f..291c4a0 100644 --- a/base/logging.h +++ b/base/logging.h @@ -99,7 +99,7 @@ // no error dialog for severity ERROR or below in normal mode. // // There is also the special severity of DFATAL, which logs FATAL in -// debug mode, ERROR_REPORT in normal mode. +// debug mode, ERROR in normal mode. namespace logging { @@ -194,9 +194,9 @@ const LogSeverity LOG_ERROR_REPORT = 3; const LogSeverity LOG_FATAL = 4; const LogSeverity LOG_NUM_SEVERITIES = 5; -// LOG_DFATAL_LEVEL is LOG_FATAL in debug mode, ERROR_REPORT in normal mode +// LOG_DFATAL_LEVEL is LOG_FATAL in debug mode, ERROR in normal mode #ifdef NDEBUG -const LogSeverity LOG_DFATAL_LEVEL = LOG_ERROR_REPORT; +const LogSeverity LOG_DFATAL_LEVEL = LOG_ERROR; #else const LogSeverity LOG_DFATAL_LEVEL = LOG_FATAL; #endif |